From 56fccd643746aff4dfa1902cd66a46a368118e05 Mon Sep 17 00:00:00 2001 From: Rashmi Kulkarni Date: Wed, 3 Feb 2021 09:53:16 -0800 Subject: [PATCH 1/2] fixing a skipped test --- x-pack/test/functional/apps/security/management.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/x-pack/test/functional/apps/security/management.js b/x-pack/test/functional/apps/security/management.js index c263b26406857e..50e084df380e4c 100644 --- a/x-pack/test/functional/apps/security/management.js +++ b/x-pack/test/functional/apps/security/management.js @@ -19,8 +19,7 @@ export default function ({ getService, getPageObjects }) { const EDIT_ROLES_PATH = `${ROLES_PATH}/edit`; const CLONE_ROLES_PATH = `${ROLES_PATH}/clone`; - // FLAKY: https://github.com/elastic/kibana/issues/61173 - describe.skip('Management', function () { + describe('Management', function () { this.tags(['skipFirefox']); before(async () => { @@ -149,7 +148,7 @@ export default function ({ getService, getPageObjects }) { await PageObjects.settings.navigateTo(); await testSubjects.click('users'); - await PageObjects.settings.clickLinkText('kibana_dashboard_only_user'); + await PageObjects.settings.clickByButtonText('kibana_dashboard_only_user'); const currentUrl = await browser.getCurrentUrl(); expect(currentUrl).to.contain(EDIT_ROLES_PATH); }); From 9709ba8875bea5b61f560a0575827641b16a46f8 Mon Sep 17 00:00:00 2001 From: Rashmi Kulkarni Date: Wed, 3 Feb 2021 10:09:47 -0800 Subject: [PATCH 2/2] settings page - clickByButtonText --- test/functional/page_objects/settings_page.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/functional/page_objects/settings_page.ts b/test/functional/page_objects/settings_page.ts index f454195bc601e0..4c8cd288ef43b6 100644 --- a/test/functional/page_objects/settings_page.ts +++ b/test/functional/page_objects/settings_page.ts @@ -28,6 +28,11 @@ export function SettingsPageProvider({ getService, getPageObjects }: FtrProvider async clickLinkText(text: string) { await find.clickByDisplayedLinkText(text); } + + async clickByButtonText(text: string) { + await find.clickByButtonText(text); + } + async clickKibanaSettings() { await testSubjects.click('settings'); await PageObjects.header.waitUntilLoadingHasFinished();