From 22e10b461d67c05fcf3786e95ca21c282d848e89 Mon Sep 17 00:00:00 2001 From: Constance Chen Date: Thu, 28 Jan 2021 10:47:18 -0800 Subject: [PATCH 1/2] Fix Cloud instructions copy when cloudDeploymentLink is missing --- .../applications/shared/setup_guide/cloud/instructions.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/enterprise_search/public/applications/shared/setup_guide/cloud/instructions.tsx b/x-pack/plugins/enterprise_search/public/applications/shared/setup_guide/cloud/instructions.tsx index 383fd4b11108a4..93678a50e98857 100644 --- a/x-pack/plugins/enterprise_search/public/applications/shared/setup_guide/cloud/instructions.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/shared/setup_guide/cloud/instructions.tsx @@ -37,7 +37,7 @@ export const CloudSetupInstructions: React.FC = ({ productName, cloudDepl edit your deployment ) : ( - 'Visit the Elastic Cloud console' + 'edit your deployment' ), }} /> From fdaeccae5e672af3ef6318ad56062594531c3d9b Mon Sep 17 00:00:00 2001 From: Constance Chen Date: Thu, 28 Jan 2021 10:48:06 -0800 Subject: [PATCH 2/2] Fix missing i18n translations on copy nested within links --- .../shared/setup_guide/cloud/instructions.tsx | 20 +++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/x-pack/plugins/enterprise_search/public/applications/shared/setup_guide/cloud/instructions.tsx b/x-pack/plugins/enterprise_search/public/applications/shared/setup_guide/cloud/instructions.tsx index 93678a50e98857..b47a5efc2d2f1e 100644 --- a/x-pack/plugins/enterprise_search/public/applications/shared/setup_guide/cloud/instructions.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/shared/setup_guide/cloud/instructions.tsx @@ -34,10 +34,16 @@ export const CloudSetupInstructions: React.FC = ({ productName, cloudDepl values={{ editDeploymentLink: cloudDeploymentLink ? ( - edit your deployment + {i18n.translate( + 'xpack.enterpriseSearch.setupGuide.cloud.step1.instruction1LinkText', + { defaultMessage: 'edit your deployment' } + )} ) : ( - 'edit your deployment' + i18n.translate( + 'xpack.enterpriseSearch.setupGuide.cloud.step1.instruction1LinkText', + { defaultMessage: 'edit your deployment' } + ) ), }} /> @@ -76,7 +82,10 @@ export const CloudSetupInstructions: React.FC = ({ productName, cloudDepl href={`${ENT_SEARCH_DOCS_PREFIX}/configuration.html`} target="_blank" > - configurable options + {i18n.translate( + 'xpack.enterpriseSearch.setupGuide.cloud.step3.instruction1LinkText', + { defaultMessage: 'configurable options' } + )} ), }} @@ -118,7 +127,10 @@ export const CloudSetupInstructions: React.FC = ({ productName, cloudDepl href={`${CLOUD_DOCS_PREFIX}/ec-configure-index-management.html`} target="_blank" > - configure an index lifecycle policy + {i18n.translate( + 'xpack.enterpriseSearch.setupGuide.cloud.step5.instruction1LinkText', + { defaultMessage: 'configure an index lifecycle policy' } + )} ), }}