[Discover] Migrate discover.html Angular template to React

src/plugins/discover/public/application/_discover.scss

@@ -104,7 +104,7 @@ discover-app {
   top: $euiSizeXS;
 }
 
-[fixed-scroll] {
+.fixed-scroll {
   overflow-x: auto;
   padding-bottom: 0;
 

src/plugins/discover/public/application/angular/directives/debounce/debounce.js

@@ -21,7 +21,7 @@ import _ from 'lodash';
 // Debounce service, angularized version of lodash debounce
 // borrowed heavily from https://github.com/shahata/angular-debounce
 
-export function DebounceProviderTimeout($timeout) {
+export function createDebounceProviderTimeout($timeout) {
   return function (func, wait, options) {
     let timeout;
     let args;
@@ -66,7 +66,3 @@ export function DebounceProviderTimeout($timeout) {
     return debounce;
   };
 }
-
-export function DebounceProvider(debounce) {
-  return debounce;
-}

src/plugins/discover/public/application/angular/directives/debounce/debounce.test.ts

@@ -24,7 +24,7 @@ import 'angular-sanitize';
 import 'angular-route';
 
 // @ts-ignore
-import { DebounceProvider } from './index';
+import { createDebounceProviderTimeout } from './debounce';
 import { coreMock } from '../../../../../../../core/public/mocks';
 import { initializeInnerAngularModule } from '../../../../get_inner_angular';
 import { navigationPluginMock } from '../../../../../../navigation/public/mocks';
@@ -33,7 +33,6 @@ import { initAngularBootstrap } from '../../../../../../kibana_legacy/public';
 
 describe('debounce service', function () {
   let debounce: (fn: () => void, timeout: number, options?: any) => any;
-  let debounceFromProvider: (fn: () => void, timeout: number, options?: any) => any;
   let $timeout: ITimeoutService;
   let spy: SinonSpy;
 
@@ -51,22 +50,17 @@ describe('debounce service', function () {
 
     angular.mock.module('app/discover');
 
-    angular.mock.inject(
-      ($injector: auto.IInjectorService, _$timeout_: ITimeoutService, Private: any) => {
-        $timeout = _$timeout_;
+    angular.mock.inject(($injector: auto.IInjectorService, _$timeout_: ITimeoutService) => {
+      $timeout = _$timeout_;
 
-        debounce = $injector.get('debounce');
-        debounceFromProvider = Private(DebounceProvider);
-      }
-    );
+      debounce = createDebounceProviderTimeout($timeout);
+    });
   });
 
   it('should have a cancel method', function () {
     const bouncer = debounce(() => {}, 100);
-    const bouncerFromProvider = debounceFromProvider(() => {}, 100);
 
     expect(bouncer).toHaveProperty('cancel');
-    expect(bouncerFromProvider).toHaveProperty('cancel');
   });
 
   describe('delayed execution', function () {
@@ -77,62 +71,40 @@ describe('debounce service', function () {
 
     it('should delay execution', function () {
       const bouncer = debounce(spy, 100);
-      const bouncerFromProvider = debounceFromProvider(spy, 100);
 
       bouncer();
       sinon.assert.notCalled(spy);
       $timeout.flush();
       sinon.assert.calledOnce(spy);
 
       spy.resetHistory();
-
-      bouncerFromProvider();
-      sinon.assert.notCalled(spy);
-      $timeout.flush();
-      sinon.assert.calledOnce(spy);
     });
 
     it('should fire on leading edge', function () {
       const bouncer = debounce(spy, 100, { leading: true });
-      const bouncerFromProvider = debounceFromProvider(spy, 100, { leading: true });
 
       bouncer();
       sinon.assert.calledOnce(spy);
       $timeout.flush();
       sinon.assert.calledTwice(spy);
 
       spy.resetHistory();
-
-      bouncerFromProvider();
-      sinon.assert.calledOnce(spy);
-      $timeout.flush();
-      sinon.assert.calledTwice(spy);
     });
 
     it('should only fire on leading edge', function () {
       const bouncer = debounce(spy, 100, { leading: true, trailing: false });
-      const bouncerFromProvider = debounceFromProvider(spy, 100, {
-        leading: true,
-        trailing: false,
-      });
 
       bouncer();
       sinon.assert.calledOnce(spy);
       $timeout.flush();
       sinon.assert.calledOnce(spy);
 
       spy.resetHistory();
-
-      bouncerFromProvider();
-      sinon.assert.calledOnce(spy);
-      $timeout.flush();
-      sinon.assert.calledOnce(spy);
     });
 
     it('should reset delayed execution', function () {
       const cancelSpy = sinon.spy($timeout, 'cancel');
       const bouncer = debounce(spy, 100);
-      const bouncerFromProvider = debounceFromProvider(spy, 100);
 
       bouncer();
       sandbox.clock.tick(1);
@@ -145,23 +117,13 @@ describe('debounce service', function () {
 
       spy.resetHistory();
       cancelSpy.resetHistory();
-
-      bouncerFromProvider();
-      sandbox.clock.tick(1);
-
-      bouncerFromProvider();
-      sinon.assert.notCalled(spy);
-      $timeout.flush();
-      sinon.assert.calledOnce(spy);
-      sinon.assert.calledOnce(cancelSpy);
     });
   });
 
   describe('cancel', function () {
     it('should cancel the $timeout', function () {
       const cancelSpy = sinon.spy($timeout, 'cancel');
       const bouncer = debounce(spy, 100);
-      const bouncerFromProvider = debounceFromProvider(spy, 100);
 
       bouncer();
       bouncer.cancel();
@@ -170,12 +132,6 @@ describe('debounce service', function () {
       $timeout.verifyNoPendingTasks();
 
       cancelSpy.resetHistory();
-
-      bouncerFromProvider();
-      bouncerFromProvider.cancel();
-      sinon.assert.calledOnce(cancelSpy);
-      // throws if pending timeouts
-      $timeout.verifyNoPendingTasks();
     });
   });
 });

src/plugins/discover/public/application/angular/directives/debounce/index.js

@@ -17,6 +17,4 @@
  * under the License.
  */
 
-import './debounce';
-
-export { DebounceProvider } from './debounce';
+export { createDebounceProviderTimeout } from './debounce';