Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Migrate discover.html Angular template to React #75784

Merged

Conversation

kertal
Copy link
Member

@kertal kertal commented Aug 24, 2020

Summary

This PR removes the Angular template discover.html, converts it into DiscoverLegacy.tsx, a React component. Discover's doc table is still in Angular, so this is also converted into a React Component DocTableLegacy, that's a wrapper for an Angular directive. So we're basically turn the table. Before, it was React in Angular, now it's Angular in React. This enables us to continue deangularization (controller, embeddable, router) without being blocked by the one indomitable gallic village of Angular in a React occupied plugin.

Checklist

Delete any items that are not applicable to this PR.

@kertal kertal self-assigned this Aug 24, 2020
@kertal kertal added the Feature:Discover Discover Application label Aug 24, 2020
@kertal kertal marked this pull request as ready for review September 4, 2020 14:16
@kertal kertal requested a review from a team September 4, 2020 14:16
…thub.com:kertal/kibana into kertal-2020-08-24-discover-migrate-discover-html
@kertal
Copy link
Member Author

kertal commented Sep 14, 2020

@kertal Is this ready to be reviewed again?

@flash1293 yes, if Jenkins goes green 🌲 🍏 💚

@kertal kertal requested review from flash1293 and removed request for a team September 14, 2020 13:31
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome and Firefox and didn't notice any issues. Looks good to me once the aria-expanded I commented on is fixed

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming issue on the scss.

src/plugins/discover/public/application/_discover.scss Outdated Show resolved Hide resolved
@kertal kertal requested review from cchaos and snide September 16, 2020 07:26
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a few seemingly arbitrary pixel values in the SASS, but I'll 👍 for now to unblock progress.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
discover 256 -3 259

async chunks size

id value diff baseline
discover 438.3KB +7.1KB 431.2KB

page load bundle size

id value diff baseline
discover 230.0KB +104.0B 229.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kertal kertal merged commit 0dc0f1f into elastic:master Sep 17, 2020
kertal added a commit to kertal/kibana that referenced this pull request Sep 17, 2020
…5784)

Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
kertal added a commit that referenced this pull request Sep 17, 2020
…77704)

Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
@kertal kertal mentioned this pull request Oct 7, 2020
1 task
@kertal kertal deleted the kertal-2020-08-24-discover-migrate-discover-html branch February 9, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants