[Ingest Manager] Update fleet instructions to run agent as a service #73491
Conversation
nchaulet
added
v8.0.0
release_note:skip
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
|
I didn't realize the ps1 script was going to be able to start up the service - this is great, thank you for updating the language. Knowing this, I think we could remove the whole Windows footnote that starts 'Alternatively, you can...'. It isn't helpful to guide them to the lesser path, that I can tell. And, leaving as it is, might be interpreted as users thinking they can skip both commands, skipping the enrollment - which they cannot. So, I'd like to see the line removed if we can? @hbharding |
|
Looks good to me, @mostlyjason ? |
|
Just removed the |
|
@elasticmachine merge upstream |
| const macOsLinuxTarCommand = ` | ||
| ./elastic-agent enroll ${enrollArgs} | ||
| ./elastic-agent run`; | ||
|
|
||
| const linuxDebRpmCommand = ` | ||
| ./elastic-agent enroll ${enrollArgs} | ||
| systemctl enable elastic-agent | ||
| systemctl start elastic-agent`; | ||
|
|
||
| const windowsCommand = ` | ||
| ./elastic-agent enroll ${enrollArgs} | ||
| ./install-service-elastic-agent.ps1`; |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
I can't comment to formal style guides, but it feels more readable to me here as committed.
There was a problem hiding this comment.
this suggestion doesn't affect how the commands are displayed in the UI. however this suggestion is probably no longer relevant due to #73491 (comment)
| <EuiSpacer size="l" /> | ||
| <EuiText> | ||
| <FormattedMessage | ||
| id="xpack.ingestManager.enrollmentInstructions.macLinuxTarInstructions" |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
yes - its specific to any of the .tar.gz usage which do not currently support persistent Agent installs.
There was a problem hiding this comment.
thanks @EricDavisX. in that case I would suggest moving this under macOS/Linux heading as a small and subdued color subtitle. the current placement made me think this was applicable to all instructions
| <EuiText> | ||
| <FormattedMessage | ||
| id="xpack.ingestManager.enrollmentInstructions.macLinuxTarInstructions" | ||
| defaultMessage="You will need to run {command} if the agent’s system reboots. This is a known limitiation in 7.9." |
There was a problem hiding this comment.
I feel that we don't need to call the release version here. @dedemorton can you suggest better text for this?
There was a problem hiding this comment.
@jen-huang @dedemorton I think it is very helpful to have *some message here about persistence support. However if we wish to change it to say 'current release' instead of '7.9' I won't argue it, except to say it would be good to get this in all the sooner to get the back-port done.
There was a problem hiding this comment.
@jen-huang Looks like you worked this out? I think it's best to describe what users need to do rather than calling this out as a known limitation in this version.
...nager/public/applications/ingest_manager/components/enrollment_instructions/manual/index.tsx
Outdated
Show resolved
Hide resolved
...nager/public/applications/ingest_manager/components/enrollment_instructions/manual/index.tsx
Outdated
Show resolved
Hide resolved
...nager/public/applications/ingest_manager/components/enrollment_instructions/manual/index.tsx
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
Summary
Resolve #73135
Update instructions to run agent as a service.
This will be backported to 7.9 as it's a prerequisite for the endpoint plugin.
@hbharding I updated the instructions on windows to click on services as the script is doing it automatically.
UI Change