Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] Make composite size configurable to avoid max buckets #72955

Merged
merged 2 commits into from
Jul 28, 2020
Merged

[Metrics UI] Make composite size configurable to avoid max buckets #72955

merged 2 commits into from
Jul 28, 2020

Conversation

simianhacker
Copy link
Member

Summary

This PR fixes #72367 by decreasing the composite aggregation size to 5 to avoid the "max bucket issue" for the Metrics UI request for the Observability homepage. The buckets are calculated by {number of buckets} * ({number of network traffic metrics} * 10) * {composite aggregation size} In the "real world" that works out to be 180 * 20 * 75 which is beyond the max_bucketdefault threshold of 20000.

Checklist

Delete any items that are not applicable to this PR.

@simianhacker simianhacker added Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 22, 2020
@simianhacker simianhacker added this to the Logs UI 7.9 milestone Jul 22, 2020
@simianhacker
Copy link
Member Author

@hendry-lim @cauemarcondes Can you check to see if this fixes the issue you're having? I wasn't able to reproduce it locally but based on the error you're seeing in #72367 I'm confident it will fix it.

@simianhacker simianhacker marked this pull request as ready for review July 22, 2020 22:33
@simianhacker simianhacker requested a review from a team as a code owner July 22, 2020 22:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@hendry-lim
Copy link

@simianhacker I just tried to set up my Kibana dev environment, but failed at yarn kbn bootstrap with errors. I will wait till this PR is merged and a Docker snapshot build is published to try this out. Thank you for your help.

@simianhacker
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
infra 3.6MB +64.0B 3.6MB

page load bundle size

id value diff baseline
infra 291.7KB +24.0B 291.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

phillipb
phillipb approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simianhacker simianhacker merged commit 2d8a41d into elastic:master Jul 28, 2020
@simianhacker simianhacker mentioned this pull request Jul 28, 2020
Merged
simianhacker added a commit to simianhacker/kibana that referenced this pull request Jul 28, 2020
@simianhacker @elasticmachine
[Metrics UI] Make composite size configurable to avoid max buckets (e…
5084a9b 
…lastic#72955)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@simianhacker simianhacker mentioned this pull request Jul 28, 2020
Merged
simianhacker added a commit to simianhacker/kibana that referenced this pull request Jul 28, 2020
@simianhacker @elasticmachine
[Metrics UI] Make composite size configurable to avoid max buckets (e…
4c5ddeb 
…lastic#72955)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
simianhacker added a commit that referenced this pull request Jul 28, 2020
@simianhacker @elasticmachine
[Metrics UI] Make composite size configurable to avoid max buckets (#…
34fee44 
…72955) (#73537)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
simianhacker added a commit that referenced this pull request Jul 28, 2020
@simianhacker @elasticmachine
[Metrics UI] Make composite size configurable to avoid max buckets (#…
7f1ae4c 
…72955) (#73536)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@simianhacker simianhacker deleted the issue-72367-make-composite-size-configurable branch April 17, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipb phillipb phillipb approved these changes

Assignees
No one assigned
Labels
Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Milestone
Logs UI 7.9
5 participants
@simianhacker @elasticmachine @hendry-lim @kibanamachine @phillipb