From 1bbacf6ae43bcb5f4ab015d1fd3c737aa2f7a1ad Mon Sep 17 00:00:00 2001 From: Yulia Cech Date: Mon, 11 May 2020 13:26:42 +0200 Subject: [PATCH 1/3] changes index mapping api response to plural form --- .../server/routes/api/mapping/register_mapping_route.ts | 4 ++-- .../apis/management/index_management/mapping.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/x-pack/plugins/index_management/server/routes/api/mapping/register_mapping_route.ts b/x-pack/plugins/index_management/server/routes/api/mapping/register_mapping_route.ts index 20d7e6b4d72329..35121af2232077 100644 --- a/x-pack/plugins/index_management/server/routes/api/mapping/register_mapping_route.ts +++ b/x-pack/plugins/index_management/server/routes/api/mapping/register_mapping_route.ts @@ -13,9 +13,9 @@ const paramsSchema = schema.object({ }); function formatHit(hit: { [key: string]: { mappings: any } }, indexName: string) { - const mapping = hit[indexName].mappings; + const mappings = hit[indexName].mappings; return { - mapping, + mappings, }; } diff --git a/x-pack/test/api_integration/apis/management/index_management/mapping.js b/x-pack/test/api_integration/apis/management/index_management/mapping.js index fa0f6e04a7a4df..2b786542553de6 100644 --- a/x-pack/test/api_integration/apis/management/index_management/mapping.js +++ b/x-pack/test/api_integration/apis/management/index_management/mapping.js @@ -32,7 +32,7 @@ export default function({ getService }) { const { body } = await getIndexMapping(index).expect(200); - expect(body.mapping).to.eql(mappings); + expect(body.mappings).to.eql(mappings); }); }); } From 65418ead607ddb2e22907bfa2a8863f39ca8b28d Mon Sep 17 00:00:00 2001 From: Yulia Cech Date: Tue, 12 May 2020 17:42:59 +0200 Subject: [PATCH 2/3] changes tab title to "Mappings" in Index Management detail panel --- .../sections/home/index_list/detail_panel/detail_panel.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/index_management/public/application/sections/home/index_list/detail_panel/detail_panel.js b/x-pack/plugins/index_management/public/application/sections/home/index_list/detail_panel/detail_panel.js index e0128b1d51d02e..b891acee36e208 100644 --- a/x-pack/plugins/index_management/public/application/sections/home/index_list/detail_panel/detail_panel.js +++ b/x-pack/plugins/index_management/public/application/sections/home/index_list/detail_panel/detail_panel.js @@ -43,7 +43,7 @@ const tabToHumanizedMap = { ), [TAB_MAPPING]: ( - + ), [TAB_STATS]: ( From dd8a4b623c9d06e5389377d874ff36a351bf0e45 Mon Sep 17 00:00:00 2001 From: Yulia Cech Date: Wed, 13 May 2020 13:50:10 +0200 Subject: [PATCH 3/3] updates index management jest snapshots for "Mappings" title --- .../__jest__/components/__snapshots__/index_table.test.js.snap | 2 +- .../index_management/__jest__/components/index_table.test.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/x-pack/plugins/index_management/__jest__/components/__snapshots__/index_table.test.js.snap b/x-pack/plugins/index_management/__jest__/components/__snapshots__/index_table.test.js.snap index 1b8f28569fedc0..38d97fbe08101d 100644 --- a/x-pack/plugins/index_management/__jest__/components/__snapshots__/index_table.test.js.snap +++ b/x-pack/plugins/index_management/__jest__/components/__snapshots__/index_table.test.js.snap @@ -170,7 +170,7 @@ Array [ ] `; -exports[`index table show mapping button works from context menu 1`] = `"Mapping"`; +exports[`index table show mappings button works from context menu 1`] = `"Mappings"`; exports[`index table show settings button works from context menu 1`] = `"Settings"`; diff --git a/x-pack/plugins/index_management/__jest__/components/index_table.test.js b/x-pack/plugins/index_management/__jest__/components/index_table.test.js index 84fbc04aa5a313..5e3edc78da5a85 100644 --- a/x-pack/plugins/index_management/__jest__/components/index_table.test.js +++ b/x-pack/plugins/index_management/__jest__/components/index_table.test.js @@ -354,7 +354,7 @@ describe('index table', () => { test('show settings button works from context menu', () => { testEditor(0); }); - test('show mapping button works from context menu', () => { + test('show mappings button works from context menu', () => { testEditor(1); }); test('show stats button works from context menu', () => {