Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust kibana app owning files #65064

Merged
merged 1 commit into from
May 4, 2020
Merged

Adjust kibana app owning files #65064

merged 1 commit into from
May 4, 2020

Conversation

sulemanof
Copy link
Contributor

Summary

This adds missing folders to kibana app owners: vis_default_editor, vis_type_tagcloud, vis_type_vega and rearranged alphabetically.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@sulemanof sulemanof requested a review from flash1293 May 4, 2020 11:33
flash1293
flash1293 approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for sorting that out!

@sulemanof sulemanof marked this pull request as ready for review May 4, 2020 11:44
@sulemanof sulemanof added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels May 4, 2020
@sulemanof sulemanof merged commit 5754912 into elastic:master May 4, 2020
@sulemanof sulemanof deleted the np/adjust_codeowners branch May 4, 2020 11:45
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 4, 2020
@gmmorris
Merge branch 'alerting/np-tests-migration' of github.com:gmmorris/kib…
85a6679 
…ana into alerting/np-tests-migration

* 'alerting/np-tests-migration' of github.com:gmmorris/kibana:
  [APM] Agent remote config: validation for Java agent configs (elastic#63956)
  [APM] Fix duplicate index patterns (elastic#64883)
  Drilldowns (elastic#61219)
  [Alerting] fix labels and links in PagerDuty action ui and docs (elastic#64032)
  [Event Log] Ensure sorting tests are less flaky (elastic#64781)
  update endpoint to restrict removing with datasources (elastic#64978)
  [Logs UI] [Alerting] Alerts management page enhancements (elastic#64654)
  Adjust kibana app owning files (elastic#65064)
  Migrate tutorial resources (elastic#64298)
  [Logs UI] Tweak copy in log alerts dialog (elastic#64645)
  [Logs UI] [Alerting] Documentation (elastic#64886)
  [Logs UI] Add dataset filter to ML module setup screen (elastic#64470)
  [TSVB] Fixing memory leak (elastic#64918)
  Bump backport to 5.4.1 (elastic#65041)
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 6, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 65064 or prevent reminders by adding the backport:skip label.

@flash1293 flash1293 added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sulemanof @kibanamachine @flash1293