Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add related event generation to ancestor nodes (fixes a bug) #64950

Merged
merged 6 commits into from
May 6, 2020
Merged

add related event generation to ancestor nodes (fixes a bug) #64950

merged 6 commits into from
May 6, 2020

Conversation

bkimmel
Copy link
Contributor

@bkimmel bkimmel commented Apr 30, 2020

Summary

This PR adjusts the ancestor generation logic to include related event generation (per the parameters supplied from the CLI)

Without this, ancestor nodes in the Resolver tree get generated without any related events regardless of the parameters supplied to the CLI.

@bkimmel bkimmel added Feature:Resolver Security Solution Resolver feature Feature:Endpoint Elastic Endpoint feature labels Apr 30, 2020
@bkimmel bkimmel requested review from a team as code owners April 30, 2020 18:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Resolver)

@bkimmel bkimmel added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes and removed v8.0.0 labels Apr 30, 2020
@bkimmel bkimmel mentioned this pull request Apr 30, 2020
2 tasks
@bkimmel
Copy link
Contributor Author

bkimmel commented May 5, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bkimmel bkimmel merged commit e977df4 into elastic:master May 6, 2020
@bkimmel bkimmel deleted the endpoint/add-related-to-generated-ancestors branch May 6, 2020 01:48
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 6, 2020
* master: (72 commits)
  add tsvb tests to Firefox suite (elastic#65425)
  Fix flaky ServerMetricsCollector integration test (elastic#65420)
  [APM] Custom links section inside the Actions menu is showing outside of the menu (elastic#65428)
  [ML] Adds docs_per_second to transform edit form. (elastic#65365)
  update apm index pattern (elastic#65424)
  add direct build command (elastic#65431)
  [ML] Adding daily_model_snapshot_retention_after_days to types and schemas (elastic#65417)
  [chore] Improve request cancelation handling in vis embeddable (elastic#65057)
  [Alerting] migrates acceptance and functional test fixtures to KP (elastic#64888)
  [ML] Fixes reordering in view by selection when overall cell selected (elastic#65290)
  Additional branding updates (elastic#64712)
  Remove redundant formatting of percentage column (elastic#64948)
  [SIEM][CASE] Configuration pages UI redesign (elastic#65355)
  New nav (elastic#64018)
  [Ingest pipelines] Address copy feedback (elastic#65175)
  bug fixing (elastic#65387)
  skip whole suite blocking snapshots (elastic#65377)
  add related event generation to ancestor nodes (fixes a bug) (elastic#64950)
  [Canvas] move files from legacy/plugins to plugins (elastic#65283)
  [SIEM] template timeline UI (elastic#64439)
  ...
bkimmel added a commit that referenced this pull request May 7, 2020
…#65715)

* add related event generation to ancestor nodes
* fix tests to account for alert at n-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Endpoint Elastic Endpoint feature Feature:Resolver Security Solution Resolver feature release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants