Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Certificates page #64059

Merged
merged 58 commits into from
May 1, 2020
Merged

[Uptime] Certificates page #64059

merged 58 commits into from
May 1, 2020

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Apr 21, 2020 •
edited
Loading

Summary

Fixes: elastic/uptime#161
Added Cert Page
image

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Apr 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

katrin-freihofner
katrin-freihofner reviewed Apr 22, 2020
View reviewed changes
Copy link
Contributor

@katrin-freihofner katrin-freihofner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

x-pack/legacy/plugins/uptime/public/components/certificates/cert_status.tsx Outdated Show resolved Hide resolved
x-pack/legacy/plugins/uptime/public/components/certificates/certificates_list.tsx Outdated Show resolved Hide resolved
x-pack/legacy/plugins/uptime/public/components/certificates/certificates_list.tsx Outdated Show resolved Hide resolved
x-pack/legacy/plugins/uptime/public/components/certificates/translations.ts Outdated Show resolved Hide resolved
x-pack/legacy/plugins/uptime/public/components/certificates/translations.ts Outdated Show resolved Hide resolved
x-pack/legacy/plugins/uptime/public/components/overview/monitor_list/cert_status_column.tsx Outdated Show resolved Hide resolved
x-pack/legacy/plugins/uptime/public/components/overview/monitor_list/cert_status_column.tsx Outdated Show resolved Hide resolved
x-pack/legacy/plugins/uptime/public/components/overview/monitor_list/monitor_list.tsx Outdated Show resolved Hide resolved
x-pack/legacy/plugins/uptime/public/pages/certificates.tsx Outdated Show resolved Hide resolved
x-pack/legacy/plugins/uptime/public/components/overview/monitor_list/monitor_list.tsx Outdated Show resolved Hide resolved
@tylersmalley tylersmalley added v7.8.0 and removed v7.8 labels Apr 29, 2020
andrewvc
andrewvc requested changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some minor changes. Overall, very clean code!

x-pack/plugins/uptime/public/components/certificates/__tests__/cert_status.test.tsx Outdated Show resolved Hide resolved
x-pack/plugins/uptime/public/components/certificates/certificates_list.tsx Outdated Show resolved Hide resolved
...time/public/components/monitor/monitor_status_details/monitor_status_bar/ssl_certificate.tsx Outdated Show resolved Hide resolved
...ns/uptime/public/components/monitor/monitor_status_details/monitor_status_bar/status_bar.tsx Outdated Show resolved Hide resolved
x-pack/test/functional/es_archives/uptime/full_heartbeat/mappings.json Outdated Show resolved Hide resolved
justinkambic
justinkambic reviewed Apr 30, 2020
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great feature addition, and the code is super clean and well thought-out.

I had a few comments but great that we're this close on an initial review for such a large change!

x-pack/plugins/uptime/public/components/certificates/cert_status.tsx Outdated Show resolved Hide resolved
x-pack/plugins/uptime/public/components/certificates/cert_status.tsx Outdated Show resolved Hide resolved
x-pack/plugins/uptime/public/components/certificates/certificates_list.tsx Show resolved Hide resolved
x-pack/plugins/uptime/public/components/certificates/certificates_list.tsx Outdated Show resolved Hide resolved
x-pack/plugins/uptime/public/components/certificates/fingerprint_col.tsx Show resolved Hide resolved
x-pack/test/functional/services/uptime/certificates.ts Outdated Show resolved Hide resolved
x-pack/test/functional/services/uptime/certificates.ts Show resolved Hide resolved
x-pack/plugins/uptime/public/state/api/certificates.ts Outdated Show resolved Hide resolved
x-pack/plugins/uptime/public/state/reducers/ml_anomaly.ts Show resolved Hide resolved
x-pack/plugins/uptime/public/state/reducers/monitor_list.ts Show resolved Hide resolved
@justinkambic justinkambic mentioned this pull request Apr 30, 2020
Merged
7 tasks
andrewvc
andrewvc approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Pending @justinkambic 's changes

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 523926f into elastic:master May 1, 2020
@shahzad31 shahzad31 deleted the certificate-page branch May 1, 2020 14:04
v1v added a commit to v1v/kibana that referenced this pull request May 4, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/e2e-changes
0dd3b32 
* upstream/master: (315 commits)
  [APM] Fix failing `ApmIndices` test (elastic#64965)
  [APM] Fix paths for ts optimization script (elastic#65012)
  Use HDR for percentiles (elastic#64758)
  [EPM] fix updates available filter (elastic#64957)
  [Uptime] Certificates page (elastic#64059)
  load lens app lazily (elastic#64769)
  [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954)
  Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742)
  [data.search.aggs] Remove legacy aggs APIs. (elastic#64719)
  Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927)
  [Discover] Show doc viewer action buttons on focus (elastic#64912)
  [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932)
  [Metrics UI] Add inventory metric threshold alerts (elastic#64292)
  [Canvas] Adds edit menu (elastic#64738)
  [Canvas] Adds refresh and autoplay options to view menu (elastic#64375)
  [Lens] Trigger a filter action on click in datatable visualization (elastic#63840)
  [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450)
  [APM] Client new platform migration (elastic#64046)
  [Monitoring] NP Migration complete client cutover (elastic#62908)
  Ingest Node Pipelines UI (elastic#62321)
  ...
jloleysens added a commit to jloleysens/kibana that referenced this pull request May 4, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into pipeline-edit…
68c12f9 
…or-part-mvp-2

* 'master' of github.com:elastic/kibana: (51 commits)
  [APM] Fix failing `ApmIndices` test (elastic#64965)
  [APM] Fix paths for ts optimization script (elastic#65012)
  Use HDR for percentiles (elastic#64758)
  [EPM] fix updates available filter (elastic#64957)
  [Uptime] Certificates page (elastic#64059)
  load lens app lazily (elastic#64769)
  [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954)
  Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742)
  [data.search.aggs] Remove legacy aggs APIs. (elastic#64719)
  Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927)
  [Discover] Show doc viewer action buttons on focus (elastic#64912)
  [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932)
  [Metrics UI] Add inventory metric threshold alerts (elastic#64292)
  [Canvas] Adds edit menu (elastic#64738)
  [Canvas] Adds refresh and autoplay options to view menu (elastic#64375)
  [Lens] Trigger a filter action on click in datatable visualization (elastic#63840)
  [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450)
  [APM] Client new platform migration (elastic#64046)
  [Monitoring] NP Migration complete client cutover (elastic#62908)
  Ingest Node Pipelines UI (elastic#62321)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/common/types.ts
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx
#	x-pack/plugins/ingest_pipelines/public/shared_imports.ts
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 4, 2020
@gmmorris
Merge branch 'master' into alerting/np-tests-migration
7215df9 
* master: (44 commits)
  onEvent prop for expression component (elastic#64995)
  [APM] Fix failing `ApmIndices` test (elastic#64965)
  [APM] Fix paths for ts optimization script (elastic#65012)
  Use HDR for percentiles (elastic#64758)
  [EPM] fix updates available filter (elastic#64957)
  [Uptime] Certificates page (elastic#64059)
  load lens app lazily (elastic#64769)
  [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954)
  Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742)
  [data.search.aggs] Remove legacy aggs APIs. (elastic#64719)
  Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927)
  [Discover] Show doc viewer action buttons on focus (elastic#64912)
  [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932)
  [Metrics UI] Add inventory metric threshold alerts (elastic#64292)
  [Canvas] Adds edit menu (elastic#64738)
  [Canvas] Adds refresh and autoplay options to view menu (elastic#64375)
  [Lens] Trigger a filter action on click in datatable visualization (elastic#63840)
  [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450)
  [APM] Client new platform migration (elastic#64046)
  [Monitoring] NP Migration complete client cutover (elastic#62908)
  ...
shahzad31 added a commit to shahzad31/kibana that referenced this pull request May 4, 2020
@shahzad31
[Uptime] Certificates page (elastic#64059)
f03acae
@shahzad31 shahzad31 mentioned this pull request May 4, 2020
Merged
shahzad31 added a commit that referenced this pull request May 4, 2020
@shahzad31
[7.x] [Uptime] Certificates page (#64059) (#65052)
559644d
@andrewvc andrewvc mentioned this pull request Jun 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic left review comments

@katrin-freihofner katrin-freihofner katrin-freihofner left review comments

@andrewvc andrewvc andrewvc approved these changes

Assignees

@shahzad31 shahzad31

Labels
release_note:enhancement Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TLS/Cert validity reporting
7 participants
@shahzad31 @elasticmachine @kibanamachine @andrewvc @justinkambic @katrin-freihofner @tylersmalley