[7.7] Instrument Kibana with APM RUM agent (#44281) #62484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Instrument Kibana with APM RUM agent * make route-change transaction work with properl url * extract page-load transaction url from app link * check if app is hidden and set active:false * make distributed tracing work and merge config * remove config/apm.js and address review * address review comments * add apm.js to build tassks * move apm from dev to src * add @types/hoist-non-react-statics which is required by react rum * apply changes correctly from master
| @@ -88,6 +88,9 @@ export interface InjectedMetadataParams { | |||
| user?: Record<string, UserProvidedValues>; | |||
| }; | |||
| }; | |||
| apm: { | |||
There was a problem hiding this comment.
apm was moved inside vars metadata which is done on this PR - #53832, so this change is not required here.
| @@ -26,11 +28,22 @@ export const appEntryTemplate = bundle => ` | |||
| * context: ${bundle.getContext()} | |||
| */ | |||
| // import global polyfills | |||
There was a problem hiding this comment.
Polyfills were not added as part of the RUM instrumentation PR. This doesnt seem to be correct.
There was a problem hiding this comment.
Does ${apmImport()} still go there?
There was a problem hiding this comment.
Yes that should still be there.
vigneshshanmugam
approved these changes
Apr 3, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.7: