From 66e0cad96e5f22bfb13acba9e93ca2c3cc6204a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Casper=20Hu=CC=88bertz?= Date: Thu, 13 Feb 2020 12:55:54 +0100 Subject: [PATCH 1/3] [APM] Remove fontFamily variable (not in use) --- x-pack/legacy/plugins/apm/public/style/variables.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/x-pack/legacy/plugins/apm/public/style/variables.ts b/x-pack/legacy/plugins/apm/public/style/variables.ts index 8746e05ef3d5e1..08277cdf6bbb19 100644 --- a/x-pack/legacy/plugins/apm/public/style/variables.ts +++ b/x-pack/legacy/plugins/apm/public/style/variables.ts @@ -31,7 +31,6 @@ export function pct(value: number): string { export const borderRadius = '4px'; // Fonts -export const fontFamily = '"Open Sans", Helvetica, Arial, sans-serif'; export const fontFamilyCode = '"SFMono-Regular", Consolas, "Liberation Mono", Menlo, Courier, monospace'; From 97beff6afe4a9f8fdb7c7e45899a43f3660ca846 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Casper=20Hu=CC=88bertz?= Date: Thu, 13 Feb 2020 12:56:31 +0100 Subject: [PATCH 2/3] [APM] Update fontFamilyCode font family Matching EUI specifications --- x-pack/legacy/plugins/apm/public/style/variables.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/legacy/plugins/apm/public/style/variables.ts b/x-pack/legacy/plugins/apm/public/style/variables.ts index 08277cdf6bbb19..5a1dcc60114d30 100644 --- a/x-pack/legacy/plugins/apm/public/style/variables.ts +++ b/x-pack/legacy/plugins/apm/public/style/variables.ts @@ -32,7 +32,7 @@ export const borderRadius = '4px'; // Fonts export const fontFamilyCode = - '"SFMono-Regular", Consolas, "Liberation Mono", Menlo, Courier, monospace'; + '"Roboto Mono", Consolas, Menlo, Courier, monospace'; // Font sizes export const fontSize = '14px'; From 373724aa0ff2b60942006a7aa630634e18846af5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Casper=20Hu=CC=88bertz?= Date: Thu, 13 Feb 2020 13:00:32 +0100 Subject: [PATCH 3/3] Update snapshots --- .../List/__test__/__snapshots__/List.test.tsx.snap | 6 +++--- .../__test__/__snapshots__/Stackframe.test.tsx.snap | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/x-pack/legacy/plugins/apm/public/components/app/ErrorGroupOverview/List/__test__/__snapshots__/List.test.tsx.snap b/x-pack/legacy/plugins/apm/public/components/app/ErrorGroupOverview/List/__test__/__snapshots__/List.test.tsx.snap index a45357121354f1..ed09b71f0c31c6 100644 --- a/x-pack/legacy/plugins/apm/public/components/app/ErrorGroupOverview/List/__test__/__snapshots__/List.test.tsx.snap +++ b/x-pack/legacy/plugins/apm/public/components/app/ErrorGroupOverview/List/__test__/__snapshots__/List.test.tsx.snap @@ -305,7 +305,7 @@ exports[`ErrorGroupOverview -> List should render empty state 1`] = ` exports[`ErrorGroupOverview -> List should render with data 1`] = ` .c0 { - font-family: "SFMono-Regular",Consolas,"Liberation Mono",Menlo,Courier,monospace; + font-family: "Roboto Mono",Consolas,Menlo,Courier,monospace; } .c1 { @@ -316,7 +316,7 @@ exports[`ErrorGroupOverview -> List should render with data 1`] = ` } .c2 { - font-family: "SFMono-Regular",Consolas,"Liberation Mono",Menlo,Courier,monospace; + font-family: "Roboto Mono",Consolas,Menlo,Courier,monospace; font-size: 16px; max-width: 100%; white-space: nowrap; @@ -325,7 +325,7 @@ exports[`ErrorGroupOverview -> List should render with data 1`] = ` } .c3 { - font-family: "SFMono-Regular",Consolas,"Liberation Mono",Menlo,Courier,monospace; + font-family: "Roboto Mono",Consolas,Menlo,Courier,monospace; }