-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SavedObjectRegistryProvider from codebase #53455
Merged
kertal
merged 35 commits into
elastic:master
from
kertal:kertal-pr-2019-12-18-np-remove-SavedObjectRegistryProvider
Dec 21, 2019
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
a1c86ec
Initial version
kertal 70d7cf8
Further migrations
kertal 9b337a8
merge upstream/master
kertal 9374470
Remove ES2015 public types
kertal f94e5d3
Code improvements & cleanups
kertal ca96123
Fix test
kertal ae596fe
Merge remote-tracking branch 'upstream/master' into kertal-pr-2019-12…
kertal 03b8efb
Improve types
kertal a568b28
Merge remote-tracking branch 'upstream/master' into kertal-pr-2019-12…
kertal e2515bf
remove global angular references in graph
flash1293 59004ff
fix test
flash1293 e3b108c
Remove accidentally commited files
kertal c09e7ca
Add missing doc files
kertal e392307
Cleanup Discover
kertal 3372685
Cleanup visualize
kertal 78d4822
Cleanup visualize - remove registry
kertal 1ecab13
Cleanup visualize - plugin.ts
kertal 9cc80c2
Cleanup dashboard
kertal 17b3737
Cleanup dashboard - register
kertal e7cd3b8
merge
kertal 105748f
Merge branch 'flash1293-graph/deangularize' into kertal-pr-2019-12-18…
kertal c3a8cab
Merge remote-tracking branch 'upstream/master' into kertal-pr-2019-12…
kertal 2dcbe20
Cleanup timelion
kertal 032900d
Migrate saved_object_finder to timelion
kertal d8b384e
Remove unused SavedObjectRegistryProvider
kertal 7987d95
Fix i18n issues
kertal 4cf7a3b
merge master / fix conflicts
kertal 013e5f4
Cleanup SavedObjectRegistryProvider from discover (merge leftover)
kertal e8764c3
Merge branch 'master' into kertal-pr-2019-12-18-np-remove-SavedObject…
elasticmachine a36d340
Dashboard review changes
kertal 0f12cfe
Visualize review changes
kertal c539e7a
Merge remote-tracking branch 'upstream/master' into kertal-pr-2019-12…
kertal f21b8d9
Fix potential linting conflict in application.ts
kertal 6f9e2d5
Merge branch 'kertal-pr-2019-12-18-np-remove-SavedObjectRegistryProvi…
kertal a6eade5
Merge master/fix conflicts
kertal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
26 changes: 13 additions & 13 deletions
26
docs/development/core/server/kibana-plugin-server.basepath.get.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,13 @@ | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
[Home](./index.md) > [kibana-plugin-server](./kibana-plugin-server.md) > [BasePath](./kibana-plugin-server.basepath.md) > [get](./kibana-plugin-server.basepath.get.md) | ||
## BasePath.get property | ||
returns `basePath` value, specific for an incoming request. | ||
<b>Signature:</b> | ||
```typescript | ||
get: (request: KibanaRequest<unknown, unknown, unknown, any> | LegacyRequest) => string; | ||
``` | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
||
[Home](./index.md) > [kibana-plugin-server](./kibana-plugin-server.md) > [BasePath](./kibana-plugin-server.basepath.md) > [get](./kibana-plugin-server.basepath.get.md) | ||
|
||
## BasePath.get property | ||
|
||
returns `basePath` value, specific for an incoming request. | ||
|
||
<b>Signature:</b> | ||
|
||
```typescript | ||
(request: KibanaRequest<unknown, unknown, unknown, any> | LegacyRequest) => string; | ||
``` |
26 changes: 13 additions & 13 deletions
26
docs/development/core/server/kibana-plugin-server.basepath.set.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,13 @@ | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
[Home](./index.md) > [kibana-plugin-server](./kibana-plugin-server.md) > [BasePath](./kibana-plugin-server.basepath.md) > [set](./kibana-plugin-server.basepath.set.md) | ||
## BasePath.set property | ||
sets `basePath` value, specific for an incoming request. | ||
<b>Signature:</b> | ||
```typescript | ||
set: (request: KibanaRequest<unknown, unknown, unknown, any> | LegacyRequest, requestSpecificBasePath: string) => void; | ||
``` | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
||
[Home](./index.md) > [kibana-plugin-server](./kibana-plugin-server.md) > [BasePath](./kibana-plugin-server.basepath.md) > [set](./kibana-plugin-server.basepath.set.md) | ||
|
||
## BasePath.set property | ||
|
||
sets `basePath` value, specific for an incoming request. | ||
|
||
<b>Signature:</b> | ||
|
||
```typescript | ||
(request: KibanaRequest<unknown, unknown, unknown, any> | LegacyRequest, requestSpecificBasePath: string) => void; | ||
``` |
26 changes: 13 additions & 13 deletions
26
docs/development/core/server/kibana-plugin-server.irouter.handlelegacyerrors.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,13 @@ | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
[Home](./index.md) > [kibana-plugin-server](./kibana-plugin-server.md) > [IRouter](./kibana-plugin-server.irouter.md) > [handleLegacyErrors](./kibana-plugin-server.irouter.handlelegacyerrors.md) | ||
## IRouter.handleLegacyErrors property | ||
Wrap a router handler to catch and converts legacy boom errors to proper custom errors. | ||
<b>Signature:</b> | ||
```typescript | ||
handleLegacyErrors: <P, Q, B>(handler: RequestHandler<P, Q, B>) => RequestHandler<P, Q, B>; | ||
``` | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
||
[Home](./index.md) > [kibana-plugin-server](./kibana-plugin-server.md) > [IRouter](./kibana-plugin-server.irouter.md) > [handleLegacyErrors](./kibana-plugin-server.irouter.handlelegacyerrors.md) | ||
|
||
## IRouter.handleLegacyErrors property | ||
|
||
Wrap a router handler to catch and converts legacy boom errors to proper custom errors. | ||
|
||
<b>Signature:</b> | ||
|
||
```typescript | ||
<P, Q, B>(handler: RequestHandler<P, Q, B>) => RequestHandler<P, Q, B>; | ||
``` |
124 changes: 62 additions & 62 deletions
124
docs/development/core/server/kibana-plugin-server.routeconfig.validate.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,62 +1,62 @@ | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
[Home](./index.md) > [kibana-plugin-server](./kibana-plugin-server.md) > [RouteConfig](./kibana-plugin-server.routeconfig.md) > [validate](./kibana-plugin-server.routeconfig.validate.md) | ||
## RouteConfig.validate property | ||
A schema created with `@kbn/config-schema` that every request will be validated against. | ||
<b>Signature:</b> | ||
```typescript | ||
validate: RouteValidatorFullConfig<P, Q, B> | false; | ||
``` | ||
## Remarks | ||
You \*must\* specify a validation schema to be able to read: - url path segments - request query - request body To opt out of validating the request, specify `validate: false`<!-- -->. In this case request params, query, and body will be \*\*empty\*\* objects and have no access to raw values. In some cases you may want to use another validation library. To do this, you need to instruct the `@kbn/config-schema` library to output \*\*non-validated values\*\* with setting schema as `schema.object({}, { allowUnknowns: true })`<!-- -->; | ||
## Example | ||
```ts | ||
import { schema } from '@kbn/config-schema'; | ||
router.get({ | ||
path: 'path/{id}', | ||
validate: { | ||
params: schema.object({ | ||
id: schema.string(), | ||
}), | ||
query: schema.object({...}), | ||
body: schema.object({...}), | ||
}, | ||
}, | ||
(context, req, res,) { | ||
req.params; // type Readonly<{id: string}> | ||
console.log(req.params.id); // value | ||
}); | ||
router.get({ | ||
path: 'path/{id}', | ||
validate: false, // handler has no access to params, query, body values. | ||
}, | ||
(context, req, res,) { | ||
req.params; // type Readonly<{}>; | ||
console.log(req.params.id); // undefined | ||
}); | ||
router.get({ | ||
path: 'path/{id}', | ||
validate: { | ||
// handler has access to raw non-validated params in runtime | ||
params: schema.object({}, { allowUnknowns: true }) | ||
}, | ||
}, | ||
(context, req, res,) { | ||
req.params; // type Readonly<{}>; | ||
console.log(req.params.id); // value | ||
myValidationLibrary.validate({ params: req.params }); | ||
}); | ||
``` | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
||
[Home](./index.md) > [kibana-plugin-server](./kibana-plugin-server.md) > [RouteConfig](./kibana-plugin-server.routeconfig.md) > [validate](./kibana-plugin-server.routeconfig.validate.md) | ||
|
||
## RouteConfig.validate property | ||
|
||
A schema created with `@kbn/config-schema` that every request will be validated against. | ||
|
||
<b>Signature:</b> | ||
|
||
```typescript | ||
RouteValidatorFullConfig<P, Q, B> | false; | ||
``` | ||
|
||
## Remarks | ||
|
||
You \*must\* specify a validation schema to be able to read: - url path segments - request query - request body To opt out of validating the request, specify `validate: false`<!-- -->. In this case request params, query, and body will be \*\*empty\*\* objects and have no access to raw values. In some cases you may want to use another validation library. To do this, you need to instruct the `@kbn/config-schema` library to output \*\*non-validated values\*\* with setting schema as `schema.object({}, { allowUnknowns: true })`<!-- -->; | ||
|
||
## Example | ||
|
||
|
||
```ts | ||
import { schema } from '@kbn/config-schema'; | ||
router.get({ | ||
path: 'path/{id}', | ||
validate: { | ||
params: schema.object({ | ||
id: schema.string(), | ||
}), | ||
query: schema.object({...}), | ||
body: schema.object({...}), | ||
}, | ||
}, | ||
(context, req, res,) { | ||
req.params; // type Readonly<{id: string}> | ||
console.log(req.params.id); // value | ||
}); | ||
|
||
router.get({ | ||
path: 'path/{id}', | ||
validate: false, // handler has no access to params, query, body values. | ||
}, | ||
(context, req, res,) { | ||
req.params; // type Readonly<{}>; | ||
console.log(req.params.id); // undefined | ||
}); | ||
|
||
router.get({ | ||
path: 'path/{id}', | ||
validate: { | ||
// handler has access to raw non-validated params in runtime | ||
params: schema.object({}, { allowUnknowns: true }) | ||
}, | ||
}, | ||
(context, req, res,) { | ||
req.params; // type Readonly<{}>; | ||
console.log(req.params.id); // value | ||
myValidationLibrary.validate({ params: req.params }); | ||
}); | ||
|
||
``` | ||
|
42 changes: 21 additions & 21 deletions
42
...elopment/core/server/kibana-plugin-server.routevalidationerror._constructor_.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,21 @@ | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
[Home](./index.md) > [kibana-plugin-server](./kibana-plugin-server.md) > [RouteValidationError](./kibana-plugin-server.routevalidationerror.md) > [(constructor)](./kibana-plugin-server.routevalidationerror._constructor_.md) | ||
## RouteValidationError.(constructor) | ||
Constructs a new instance of the `RouteValidationError` class | ||
<b>Signature:</b> | ||
```typescript | ||
constructor(error: Error | string, path?: string[]); | ||
``` | ||
## Parameters | ||
| Parameter | Type | Description | | ||
| --- | --- | --- | | ||
| error | <code>Error | string</code> | | | ||
| path | <code>string[]</code> | | | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
||
[Home](./index.md) > [kibana-plugin-server](./kibana-plugin-server.md) > [RouteValidationError](./kibana-plugin-server.routevalidationerror.md) > [(constructor)](./kibana-plugin-server.routevalidationerror._constructor_.md) | ||
|
||
## RouteValidationError.(constructor) | ||
|
||
Constructs a new instance of the `RouteValidationError` class | ||
|
||
<b>Signature:</b> | ||
|
||
```typescript | ||
constructor(error;: Error | string, path?: string[];) | ||
``` | ||
|
||
## Parameters | ||
|
||
| Parameter | Type | Description | | ||
| --- | --- | --- | | ||
| error | <code>Error | string</code> | | | ||
| path | <code>string[]</code> | | | ||
|
26 changes: 13 additions & 13 deletions
26
...ent/core/server/kibana-plugin-server.routevalidationresultfactory.badrequest.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,13 @@ | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
[Home](./index.md) > [kibana-plugin-server](./kibana-plugin-server.md) > [RouteValidationResultFactory](./kibana-plugin-server.routevalidationresultfactory.md) > [badRequest](./kibana-plugin-server.routevalidationresultfactory.badrequest.md) | ||
## RouteValidationResultFactory.badRequest property | ||
<b>Signature:</b> | ||
```typescript | ||
badRequest: (error: Error | string, path?: string[]) => { | ||
error: RouteValidationError; | ||
}; | ||
``` | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
||
[Home](./index.md) > [kibana-plugin-server](./kibana-plugin-server.md) > [RouteValidationResultFactory](./kibana-plugin-server.routevalidationresultfactory.md) > [badRequest](./kibana-plugin-server.routevalidationresultfactory.badrequest.md) | ||
|
||
## RouteValidationResultFactory.badRequest property | ||
|
||
<b>Signature:</b> | ||
|
||
```typescript | ||
(error: Error | string, path?: string[]) => { | ||
RouteValidationError; | ||
}; | ||
``` |
26 changes: 13 additions & 13 deletions
26
...development/core/server/kibana-plugin-server.routevalidationresultfactory.ok.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,13 @@ | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
[Home](./index.md) > [kibana-plugin-server](./kibana-plugin-server.md) > [RouteValidationResultFactory](./kibana-plugin-server.routevalidationresultfactory.md) > [ok](./kibana-plugin-server.routevalidationresultfactory.ok.md) | ||
## RouteValidationResultFactory.ok property | ||
<b>Signature:</b> | ||
```typescript | ||
ok: <T>(value: T) => { | ||
value: T; | ||
}; | ||
``` | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
||
[Home](./index.md) > [kibana-plugin-server](./kibana-plugin-server.md) > [RouteValidationResultFactory](./kibana-plugin-server.routevalidationresultfactory.md) > [ok](./kibana-plugin-server.routevalidationresultfactory.ok.md) | ||
|
||
## RouteValidationResultFactory.ok property | ||
|
||
<b>Signature:</b> | ||
|
||
```typescript | ||
<T>(value: T) => { | ||
T; | ||
}; | ||
``` |
35 changes: 18 additions & 17 deletions
35
docs/development/core/server/kibana-plugin-server.routevalidatoroptions.unsafe.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,18 @@ | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
||
[Home](./index.md) > [kibana-plugin-server](./kibana-plugin-server.md) > [RouteValidatorOptions](./kibana-plugin-server.routevalidatoroptions.md) > [unsafe](./kibana-plugin-server.routevalidatoroptions.unsafe.md) | ||
|
||
## RouteValidatorOptions.unsafe property | ||
|
||
Set the `unsafe` config to avoid running some additional internal \*safe\* validations on top of your custom validation | ||
|
||
<b>Signature:</b> | ||
|
||
```typescript | ||
unsafe?: { | ||
params?: boolean; | ||
query?: boolean; | ||
body?: boolean; | ||
}; | ||
``` | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
||
[Home](./index.md) > [kibana-plugin-server](./kibana-plugin-server.md) > [RouteValidatorOptions](./kibana-plugin-server.routevalidatoroptions.md) > [unsafe](./kibana-plugin-server.routevalidatoroptions.unsafe.md) | ||
|
||
## RouteValidatorOptions.unsafe property | ||
|
||
Set the `unsafe` config to avoid running some additional internal \*safe\* validations on top of your custom validation | ||
|
||
<b>Signature:</b> | ||
|
||
```typescript | ||
unsafe?: { | ||
params?: boolean; | ||
query?: boolean; | ||
body?: boolean; | ||
} | ||
|
||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉Down to one, nice! We should probably just move that flag into
kibana_legacy
, then dashboard is almost ready to go (not in this PR though)