Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NP Migration: Remove global angular references in graph #53293

Merged
merged 3 commits into from
Dec 20, 2019
Merged

NP Migration: Remove global angular references in graph #53293

merged 3 commits into from
Dec 20, 2019

Conversation

flash1293
Copy link
Contributor

This PR removes some global references to make Graph ready for migration:

  • Switch to jest tests
  • Consolidate all legacy imports in one file
  • Move saved object loader out of angular (as it doesn't use any angular functionality anymore and isn't used itself)
  • Reference Storage directly as it isn't a legacy import

@flash1293 flash1293 added Feature:Graph Graph application feature Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0 labels Dec 17, 2019
@flash1293 flash1293 marked this pull request as ready for review December 17, 2019 16:15
@flash1293 flash1293 requested a review from a team December 17, 2019 16:15
@flash1293 flash1293 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Dec 17, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

kertal
kertal approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A really nice house cleanup right before 🎄 ! Code 🎁 , tested locally on Chrome

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kertal kertal mentioned this pull request Dec 20, 2019
Merged
@flash1293 flash1293 merged commit 672eac0 into elastic:master Dec 20, 2019
@flash1293 flash1293 mentioned this pull request Dec 20, 2019
Merged
flash1293 added a commit to flash1293/kibana that referenced this pull request Dec 20, 2019
@flash1293
NP Migration: Remove global angular references in graph (elastic#53293)
e8da96e
flash1293 added a commit that referenced this pull request Dec 20, 2019
@flash1293
NP Migration: Remove global angular references in graph (#53293) (#53680
4a3d7c2 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

Assignees
No one assigned
Labels
Feature:Graph Graph application feature Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flash1293 @elasticmachine @kertal