Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set IS_PIPELINE_JOB in intake jobs #45850

Merged
merged 5 commits into from
Sep 17, 2019
Merged

set IS_PIPELINE_JOB in intake jobs #45850

merged 5 commits into from
Sep 17, 2019

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Sep 16, 2019 •
edited
Loading

Since IS_PIPELINE_JOB isn't being set in intake jobs we aren't limiting the failed_tests/cli like intended by #45551.

Example issue:

Produces two notifications for the same failure:
image

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v7.3.2 v6.8.4 v7.4.1 test-pipelines labels Sep 16, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

brianseeders
brianseeders approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@brianseeders brianseeders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it should be okay. IS_PIPELINE_JOB is probably poorly-named and is kind of confusing, but the intent is that it goes away once the matrix jobs are gone.

The shell scripts will need to revert when the smoke tests move back to the parallel workers

@spalger spalger merged commit b1a01ef into elastic:master Sep 17, 2019
@spalger spalger mentioned this pull request Sep 17, 2019
Merged
spalger pushed a commit to spalger/kibana that referenced this pull request Sep 17, 2019
set IS_PIPELINE_JOB in intake jobs (elastic#45850)
503c17a 
* set IS_PIPELINE_JOB in intake jobs

* firefox smoke doesn't get an initial build

* firefox smoke doesn't get an initial build (oss edition)

* re-enable all jobs
@spalger spalger mentioned this pull request Sep 17, 2019
Merged
spalger pushed a commit to spalger/kibana that referenced this pull request Sep 17, 2019
set IS_PIPELINE_JOB in intake jobs (elastic#45850)
90d7fee 
* set IS_PIPELINE_JOB in intake jobs

* firefox smoke doesn't get an initial build

* firefox smoke doesn't get an initial build (oss edition)

* re-enable all jobs
@spalger spalger mentioned this pull request Sep 17, 2019
Merged
spalger pushed a commit to spalger/kibana that referenced this pull request Sep 17, 2019
set IS_PIPELINE_JOB in intake jobs (elastic#45850)
2cdd406 
* set IS_PIPELINE_JOB in intake jobs

* firefox smoke doesn't get an initial build

* firefox smoke doesn't get an initial build (oss edition)

* re-enable all jobs
@spalger spalger mentioned this pull request Sep 17, 2019
Merged
spalger pushed a commit to spalger/kibana that referenced this pull request Sep 17, 2019
set IS_PIPELINE_JOB in intake jobs (elastic#45850)
5195d16 
* set IS_PIPELINE_JOB in intake jobs

* firefox smoke doesn't get an initial build

* firefox smoke doesn't get an initial build (oss edition)

* re-enable all jobs

# Conflicts:
#	test/scripts/jenkins_firefox_smoke.sh
#	test/scripts/jenkins_xpack_firefox_smoke.sh
spalger pushed a commit that referenced this pull request Sep 17, 2019
[7.3] set IS_PIPELINE_JOB in intake jobs (#45850) (#45922)
dd2802d 
* set IS_PIPELINE_JOB in intake jobs

* firefox smoke doesn't get an initial build

* firefox smoke doesn't get an initial build (oss edition)

* re-enable all jobs
spalger pushed a commit that referenced this pull request Sep 17, 2019
[6.8] set IS_PIPELINE_JOB in intake jobs (#45850) (#45923)
c08c6a7 
* set IS_PIPELINE_JOB in intake jobs

* firefox smoke doesn't get an initial build

* firefox smoke doesn't get an initial build (oss edition)

* re-enable all jobs

# Conflicts:
#	test/scripts/jenkins_firefox_smoke.sh
#	test/scripts/jenkins_xpack_firefox_smoke.sh
@spalger
Copy link
Contributor Author

spalger commented Sep 17, 2019 •
edited
Loading

7.x/7.5: 745b0ba
7.4: 327a755
7.3: dd2802d
6.8: c08c6a7

rylnd added a commit to rylnd/kibana that referenced this pull request Sep 17, 2019
@rylnd
Merge branch 'master' into new-search-layout
41683c0 
* master: (33 commits)
  [easy] Exclude __examples__ from coverage (elastic#45556)
  [DOCS] Update CCR links (elastic#44012)
  Use unique junit report filenames again (elastic#45897)
  [ftr/savedObjects] add simple saved object api client to ftr s… (elastic#45856)
  New visualization editor Lens (elastic#36437)
  Sort using unix timestamp value (elastic#43162)
  [APM] Use POST instead of implicit GET (elastic#45903)
  [Canvas] Converting workpad header components to typescript and adding i18n (elastic#45274)
  skip flaky test (elastic#45884)
  set IS_PIPELINE_JOB in intake jobs (elastic#45850)
  [Uptime] Fix/issue 48 integration popup closes after refresh (elastic#45759)
  [Logs UI] Support zoom by brushing in the log rate chart (elastic#45879)
  [DOCS] Changes name to host (elastic#45798)
  [ML] Add population job wizard test (elastic#45765)
  [skip-ci][Maps][File upload] Geojson indexing and styling docs (elastic#41394)
  remove setTimeoue for state change (elastic#45853)
  [Graph] Restructure folders and add readme (elastic#45782)
  [ML] Enhance job id error message (elastic#45349)
  [SIEM] Do not update state component when they did unmount (elastic#45847)
  [i18n] sync from 7.4 latest translations (elastic#45823)
  ...
rylnd added a commit to rylnd/kibana that referenced this pull request Sep 17, 2019
@rylnd
Merge branch 'master' into new-search-layout
f27d4c8 
* master: (33 commits)
  [easy] Exclude __examples__ from coverage (elastic#45556)
  [DOCS] Update CCR links (elastic#44012)
  Use unique junit report filenames again (elastic#45897)
  [ftr/savedObjects] add simple saved object api client to ftr s… (elastic#45856)
  New visualization editor Lens (elastic#36437)
  Sort using unix timestamp value (elastic#43162)
  [APM] Use POST instead of implicit GET (elastic#45903)
  [Canvas] Converting workpad header components to typescript and adding i18n (elastic#45274)
  skip flaky test (elastic#45884)
  set IS_PIPELINE_JOB in intake jobs (elastic#45850)
  [Uptime] Fix/issue 48 integration popup closes after refresh (elastic#45759)
  [Logs UI] Support zoom by brushing in the log rate chart (elastic#45879)
  [DOCS] Changes name to host (elastic#45798)
  [ML] Add population job wizard test (elastic#45765)
  [skip-ci][Maps][File upload] Geojson indexing and styling docs (elastic#41394)
  remove setTimeoue for state change (elastic#45853)
  [Graph] Restructure folders and add readme (elastic#45782)
  [ML] Enhance job id error message (elastic#45349)
  [SIEM] Do not update state component when they did unmount (elastic#45847)
  [i18n] sync from 7.4 latest translations (elastic#45823)
  ...
spalger pushed a commit that referenced this pull request Sep 17, 2019
[7.4] set IS_PIPELINE_JOB in intake jobs (#45850) (#45921)
327a755 
* set IS_PIPELINE_JOB in intake jobs

* firefox smoke doesn't get an initial build

* firefox smoke doesn't get an initial build (oss edition)

* re-enable all jobs
spalger pushed a commit that referenced this pull request Sep 17, 2019
[7.x] set IS_PIPELINE_JOB in intake jobs (#45850) (#45920)
745b0ba 
* set IS_PIPELINE_JOB in intake jobs

* firefox smoke doesn't get an initial build

* firefox smoke doesn't get an initial build (oss edition)

* re-enable all jobs
@spalger spalger deleted the fix/only-run-failed-tests-report-once branch September 17, 2019 21:43
brianseeders added a commit to brianseeders/kibana that referenced this pull request Sep 23, 2019
@brianseeders
Re-combine ciGroups
a82785d 
Revert "Revert "Revert "Revert "Revert "[ci] compress jobs for CI stab… (elastic#45454)"

This reverts commit 9a109f2.

Revert "set IS_PIPELINE_JOB in intake jobs (elastic#45850)"

This reverts commit b1a01ef.
brianseeders added a commit to brianseeders/kibana that referenced this pull request Sep 23, 2019
@brianseeders
Re-split ciGroups after pipeline rollout
b9ba18e 
Revert "Revert "Revert "Revert "Revert "[ci] compress jobs for CI stab… (elastic#45454)"

This reverts commit 9a109f2.

Revert "set IS_PIPELINE_JOB in intake jobs (elastic#45850)"

This reverts commit b1a01ef.
spalger pushed a commit that referenced this pull request Sep 25, 2019
@brianseeders
Re-split ciGroups after pipeline rollout (#46375)
cafc857 
* Re-split ciGroups after pipeline rollout

Revert "Revert "Revert "Revert "Revert "[ci] compress jobs for CI stab… (#45454)"

This reverts commit 9a109f2.

Revert "set IS_PIPELINE_JOB in intake jobs (#45850)"

This reverts commit b1a01ef.

* Split one of the slow test suites up to try to make overall CI faster

* Disable visualRegression groups, they are being handled in other work

* Revert "Split one of the slow test suites up to try to make overall CI faster"

This reverts commit 1213239.

* Move some different xpack ciGroup8 suites around
spalger pushed a commit to spalger/kibana that referenced this pull request Sep 25, 2019
@brianseeders
Re-split ciGroups after pipeline rollout (elastic#46375)
a536585 
* Re-split ciGroups after pipeline rollout

Revert "Revert "Revert "Revert "Revert "[ci] compress jobs for CI stab… (elastic#45454)"

This reverts commit 9a109f2.

Revert "set IS_PIPELINE_JOB in intake jobs (elastic#45850)"

This reverts commit b1a01ef.

* Split one of the slow test suites up to try to make overall CI faster

* Disable visualRegression groups, they are being handled in other work

* Revert "Split one of the slow test suites up to try to make overall CI faster"

This reverts commit 1213239.

* Move some different xpack ciGroup8 suites around
spalger pushed a commit to spalger/kibana that referenced this pull request Sep 25, 2019
@brianseeders
Re-split ciGroups after pipeline rollout (elastic#46375)
ffc9eb3 
* Re-split ciGroups after pipeline rollout

Revert "Revert "Revert "Revert "Revert "[ci] compress jobs for CI stab… (elastic#45454)"

This reverts commit 9a109f2.

Revert "set IS_PIPELINE_JOB in intake jobs (elastic#45850)"

This reverts commit b1a01ef.

* Split one of the slow test suites up to try to make overall CI faster

* Disable visualRegression groups, they are being handled in other work

* Revert "Split one of the slow test suites up to try to make overall CI faster"

This reverts commit 1213239.

* Move some different xpack ciGroup8 suites around
spalger pushed a commit to spalger/kibana that referenced this pull request Sep 25, 2019
@brianseeders
Re-split ciGroups after pipeline rollout (elastic#46375)
142a1dd 
* Re-split ciGroups after pipeline rollout

Revert "Revert "Revert "Revert "Revert "[ci] compress jobs for CI stab… (elastic#45454)"

This reverts commit 9a109f2.

Revert "set IS_PIPELINE_JOB in intake jobs (elastic#45850)"

This reverts commit b1a01ef.

* Split one of the slow test suites up to try to make overall CI faster

* Disable visualRegression groups, they are being handled in other work

* Revert "Split one of the slow test suites up to try to make overall CI faster"

This reverts commit 1213239.

* Move some different xpack ciGroup8 suites around

# Conflicts:
#	x-pack/test/alerting_api_integration/security_and_spaces/tests/index.ts
#	x-pack/test/alerting_api_integration/spaces_only/tests/index.ts
#	x-pack/test/oidc_api_integration/apis/authorization_code_flow/index.js
#	x-pack/test/oidc_api_integration/apis/implicit_flow/index.ts
#	x-pack/test/pki_api_integration/apis/index.ts
#	x-pack/test/visual_regression/tests/maps/index.js
spalger pushed a commit to spalger/kibana that referenced this pull request Sep 25, 2019
@brianseeders
Re-split ciGroups after pipeline rollout (elastic#46375)
60fe0ab 
* Re-split ciGroups after pipeline rollout

Revert "Revert "Revert "Revert "Revert "[ci] compress jobs for CI stab… (elastic#45454)"

This reverts commit 9a109f2.

Revert "set IS_PIPELINE_JOB in intake jobs (elastic#45850)"

This reverts commit b1a01ef.

* Split one of the slow test suites up to try to make overall CI faster

* Disable visualRegression groups, they are being handled in other work

* Revert "Split one of the slow test suites up to try to make overall CI faster"

This reverts commit 1213239.

* Move some different xpack ciGroup8 suites around

# Conflicts:
#	.ci/jobs.yml
#	.ci/run.sh
#	Jenkinsfile
#	test/functional/apps/visualize/index.ts
#	test/mocha_decorations.d.ts
#	test/scripts/jenkins_firefox_smoke.sh
#	test/scripts/jenkins_xpack_ci_group.sh
#	test/scripts/jenkins_xpack_firefox_smoke.sh
#	x-pack/test/alerting_api_integration/security_and_spaces/tests/index.ts
#	x-pack/test/alerting_api_integration/spaces_only/tests/index.ts
#	x-pack/test/api_integration/apis/index.js
#	x-pack/test/api_integration/apis/spaces/index.ts
#	x-pack/test/functional/apps/apm/index.ts
#	x-pack/test/functional/apps/dashboard_mode/index.js
#	x-pack/test/functional/apps/index_lifecycle_management/index.ts
#	x-pack/test/functional/apps/infra/index.ts
#	x-pack/test/functional/apps/license_management/index.ts
#	x-pack/test/functional/apps/maps/index.js
#	x-pack/test/functional/apps/uptime/index.ts
#	x-pack/test/kerberos_api_integration/apis/index.ts
#	x-pack/test/oidc_api_integration/apis/authorization_code_flow/index.js
#	x-pack/test/oidc_api_integration/apis/implicit_flow/index.ts
#	x-pack/test/pki_api_integration/apis/index.ts
#	x-pack/test/saved_object_api_integration/security_only/apis/index.ts
#	x-pack/test/spaces_api_integration/security_and_spaces/apis/index.ts
#	x-pack/test/ui_capabilities/security_and_spaces/tests/index.ts
#	x-pack/test/ui_capabilities/security_only/tests/index.ts
#	x-pack/test/ui_capabilities/spaces_only/tests/index.ts
#	x-pack/test/upgrade_assistant_integration/upgrade_assistant/index.js
#	x-pack/test/visual_regression/tests/maps/index.js
spalger pushed a commit that referenced this pull request Sep 25, 2019
[7.3] Re-split ciGroups after pipeline rollout (#46375) (#46645)
50133fa 
* Re-split ciGroups after pipeline rollout

Revert "Revert "Revert "Revert "Revert "[ci] compress jobs for CI stab… (#45454)"

This reverts commit 9a109f2.

Revert "set IS_PIPELINE_JOB in intake jobs (#45850)"

This reverts commit b1a01ef.

* Split one of the slow test suites up to try to make overall CI faster

* Disable visualRegression groups, they are being handled in other work

* Revert "Split one of the slow test suites up to try to make overall CI faster"

This reverts commit 1213239.

* Move some different xpack ciGroup8 suites around

# Conflicts:
#	x-pack/test/alerting_api_integration/security_and_spaces/tests/index.ts
#	x-pack/test/alerting_api_integration/spaces_only/tests/index.ts
#	x-pack/test/oidc_api_integration/apis/authorization_code_flow/index.js
#	x-pack/test/oidc_api_integration/apis/implicit_flow/index.ts
#	x-pack/test/pki_api_integration/apis/index.ts
#	x-pack/test/visual_regression/tests/maps/index.js
spalger pushed a commit that referenced this pull request Sep 26, 2019
[7.x] Re-split ciGroups after pipeline rollout (#46375) (#46643)
2e2e1ea 
* Re-split ciGroups after pipeline rollout

Revert "Revert "Revert "Revert "Revert "[ci] compress jobs for CI stab… (#45454)"

This reverts commit 9a109f2.

Revert "set IS_PIPELINE_JOB in intake jobs (#45850)"

This reverts commit b1a01ef.

* Split one of the slow test suites up to try to make overall CI faster

* Disable visualRegression groups, they are being handled in other work

* Revert "Split one of the slow test suites up to try to make overall CI faster"

This reverts commit 1213239.

* Move some different xpack ciGroup8 suites around
spalger pushed a commit that referenced this pull request Sep 26, 2019
[7.4] Re-split ciGroups after pipeline rollout (#46375) (#46644)
c572c01 
* Re-split ciGroups after pipeline rollout

Revert "Revert "Revert "Revert "Revert "[ci] compress jobs for CI stab… (#45454)"

This reverts commit 9a109f2.

Revert "set IS_PIPELINE_JOB in intake jobs (#45850)"

This reverts commit b1a01ef.

* Split one of the slow test suites up to try to make overall CI faster

* Disable visualRegression groups, they are being handled in other work

* Revert "Split one of the slow test suites up to try to make overall CI faster"

This reverts commit 1213239.

* Move some different xpack ciGroup8 suites around
spalger pushed a commit that referenced this pull request Sep 26, 2019
[6.8] Re-split ciGroups after pipeline rollout (#46375) (#46646)
6df1cf3 
* Re-split ciGroups after pipeline rollout

Revert "Revert "Revert "Revert "Revert "[ci] compress jobs for CI stab… (#45454)"

This reverts commit 9a109f2.

Revert "set IS_PIPELINE_JOB in intake jobs (#45850)"

This reverts commit b1a01ef.

* Split one of the slow test suites up to try to make overall CI faster

* Disable visualRegression groups, they are being handled in other work

* Revert "Split one of the slow test suites up to try to make overall CI faster"

This reverts commit 1213239.

* Move some different xpack ciGroup8 suites around

# Conflicts:
#	.ci/jobs.yml
#	.ci/run.sh
#	Jenkinsfile
#	test/functional/apps/visualize/index.ts
#	test/mocha_decorations.d.ts
#	test/scripts/jenkins_firefox_smoke.sh
#	test/scripts/jenkins_xpack_ci_group.sh
#	test/scripts/jenkins_xpack_firefox_smoke.sh
#	x-pack/test/alerting_api_integration/security_and_spaces/tests/index.ts
#	x-pack/test/alerting_api_integration/spaces_only/tests/index.ts
#	x-pack/test/api_integration/apis/index.js
#	x-pack/test/api_integration/apis/spaces/index.ts
#	x-pack/test/functional/apps/apm/index.ts
#	x-pack/test/functional/apps/dashboard_mode/index.js
#	x-pack/test/functional/apps/index_lifecycle_management/index.ts
#	x-pack/test/functional/apps/infra/index.ts
#	x-pack/test/functional/apps/license_management/index.ts
#	x-pack/test/functional/apps/maps/index.js
#	x-pack/test/functional/apps/uptime/index.ts
#	x-pack/test/kerberos_api_integration/apis/index.ts
#	x-pack/test/oidc_api_integration/apis/authorization_code_flow/index.js
#	x-pack/test/oidc_api_integration/apis/implicit_flow/index.ts
#	x-pack/test/pki_api_integration/apis/index.ts
#	x-pack/test/saved_object_api_integration/security_only/apis/index.ts
#	x-pack/test/spaces_api_integration/security_and_spaces/apis/index.ts
#	x-pack/test/ui_capabilities/security_and_spaces/tests/index.ts
#	x-pack/test/ui_capabilities/security_only/tests/index.ts
#	x-pack/test/ui_capabilities/spaces_only/tests/index.ts
#	x-pack/test/upgrade_assistant_integration/upgrade_assistant/index.js
#	x-pack/test/visual_regression/tests/maps/index.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianseeders brianseeders brianseeders approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team test-pipelines v6.8.4 v7.3.2 v7.4.1 v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spalger @elasticmachine @brianseeders