[SIEM] Do not update state component when they did unmount #45847

XavierM · 2019-09-16T22:02:09Z

Summary

We had an issue that we were still updating our async component if they did unmount because of our async call.

How to reproduce the bug:

Click on the SIEM app icon to force a full page refresh and start with clean application state
Click the Hosts tab, and wait for all the widgets on the page to load
Click on the Network tab, but do NOT wait for all the widgets to load before performing the next step
While widgets on the Network tab are still loading, click on the Hosts tab
Expected result

No errors logged in the development Console
Actual result
The following error is logged to the Console:
Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.
in Unknown (created by NetworkFilterComponent)
in NetworkFilterComponent (created by Connect(NetworkFilterComponent))
in Connect(NetworkFilterComponent)
in Unknown (created by Connect(Component))
in Connect(Component) (created by Query)
in div (created by Container)
in Container (created by Query)
in Query (created by WithSource)
in WithSource
in Unknown (created by Connect(NetworkComponent))
in Connect(NetworkComponent) (created by Route)
in Route
in Switch
in Unknown (created by Route)

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-09-16T22:02:10Z

Pinging @elastic/siem

spong · 2019-09-16T23:22:13Z

x-pack/legacy/plugins/siem/public/containers/hosts/first_last_seen/index.ts

-      updateLastSeen(null);
-      updateErrorMessage(err.toString());
-    }
+    const abortCtrl = new AbortController();


Did not know about this -- very cool!

Same, did not know about this.

That's pretty neat and fetch takes signals too and does cancels.

Also it's used throughout the kibana code base so it looks to be polyfilled and a great thing to use.

elasticmachine · 2019-09-16T23:42:11Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

x-pack/legacy/plugins/siem/public/components/ml_popover/hooks/use_index_patterns.tsx

x-pack/legacy/plugins/siem/public/components/ml_popover/hooks/use_job_summary_data.tsx

x-pack/legacy/plugins/siem/public/components/ml_popover/hooks/use_siem_jobs.tsx

Adds signals to the fetches

FrankHassanabad

Awesome changes and thanks for the Abort syntax below to use for fetches!

Love it ❤️ ❤️ !

LGTM

elasticmachine · 2019-09-17T01:56:10Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-17T02:20:38Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…5847) * do not update state component when they did unmount * Adds signals to the fetches * review I

…45860) * do not update state component when they did unmount * Adds signals to the fetches * review I

…45861) * do not update state component when they did unmount * Adds signals to the fetches * review I

* master: (33 commits) [easy] Exclude __examples__ from coverage (elastic#45556) [DOCS] Update CCR links (elastic#44012) Use unique junit report filenames again (elastic#45897) [ftr/savedObjects] add simple saved object api client to ftr s… (elastic#45856) New visualization editor Lens (elastic#36437) Sort using unix timestamp value (elastic#43162) [APM] Use POST instead of implicit GET (elastic#45903) [Canvas] Converting workpad header components to typescript and adding i18n (elastic#45274) skip flaky test (elastic#45884) set IS_PIPELINE_JOB in intake jobs (elastic#45850) [Uptime] Fix/issue 48 integration popup closes after refresh (elastic#45759) [Logs UI] Support zoom by brushing in the log rate chart (elastic#45879) [DOCS] Changes name to host (elastic#45798) [ML] Add population job wizard test (elastic#45765) [skip-ci][Maps][File upload] Geojson indexing and styling docs (elastic#41394) remove setTimeoue for state change (elastic#45853) [Graph] Restructure folders and add readme (elastic#45782) [ML] Enhance job id error message (elastic#45349) [SIEM] Do not update state component when they did unmount (elastic#45847) [i18n] sync from 7.4 latest translations (elastic#45823) ...

do not update state component when they did unmount

1373b4f

XavierM added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v7.5.0 labels Sep 16, 2019

XavierM requested review from FrankHassanabad and spong September 16, 2019 22:02

XavierM self-assigned this Sep 16, 2019

spong reviewed Sep 16, 2019

View reviewed changes

x-pack/legacy/plugins/siem/public/components/ml_popover/hooks/use_index_patterns.tsx Outdated Show resolved Hide resolved

spong reviewed Sep 16, 2019

View reviewed changes

x-pack/legacy/plugins/siem/public/components/ml_popover/hooks/use_job_summary_data.tsx Outdated Show resolved Hide resolved

spong reviewed Sep 16, 2019

View reviewed changes

x-pack/legacy/plugins/siem/public/components/ml_popover/hooks/use_siem_jobs.tsx Outdated Show resolved Hide resolved

FrankHassanabad and others added 4 commits September 16, 2019 18:04

Adds signals to the fetches

ab35f57

review I

b74711e

Merge branch 'pr/45847' into add-signals-to-fetch

6031657

Merge pull request #6 from FrankHassanabad/add-signals-to-fetch

87e3ff6

Adds signals to the fetches

FrankHassanabad approved these changes Sep 17, 2019

View reviewed changes

XavierM merged commit 677f662 into elastic:master Sep 17, 2019

XavierM added a commit to XavierM/kibana that referenced this pull request Sep 17, 2019

[SIEM] Do not update state component when they did unmount (elastic#4…

802f327

…5847) * do not update state component when they did unmount * Adds signals to the fetches * review I

XavierM mentioned this pull request Sep 17, 2019

[7.x] [SIEM] Do not update state component when they did unmount (#45847) #45860

Merged

XavierM added a commit to XavierM/kibana that referenced this pull request Sep 17, 2019

[SIEM] Do not update state component when they did unmount (elastic#4…

5130221

…5847) * do not update state component when they did unmount * Adds signals to the fetches * review I

XavierM mentioned this pull request Sep 17, 2019

[7.4] [SIEM] Do not update state component when they did unmount (#45847) #45861

Merged

XavierM added a commit that referenced this pull request Sep 17, 2019

[SIEM] Do not update state component when they did unmount (#45847) (#…

457dd1e

…45860) * do not update state component when they did unmount * Adds signals to the fetches * review I

XavierM added a commit that referenced this pull request Sep 17, 2019

[SIEM] Do not update state component when they did unmount (#45847) (#…

af150a1

…45861) * do not update state component when they did unmount * Adds signals to the fetches * review I

XavierM deleted the siem-fix-state-update branch June 4, 2020 16:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SIEM] Do not update state component when they did unmount #45847

[SIEM] Do not update state component when they did unmount #45847

XavierM commented Sep 16, 2019

elasticmachine commented Sep 16, 2019

spong Sep 16, 2019

FrankHassanabad Sep 17, 2019 •

edited

Loading

FrankHassanabad Sep 17, 2019

elasticmachine commented Sep 16, 2019

FrankHassanabad left a comment

elasticmachine commented Sep 17, 2019

elasticmachine commented Sep 17, 2019

[SIEM] Do not update state component when they did unmount #45847

[SIEM] Do not update state component when they did unmount #45847

Conversation

XavierM commented Sep 16, 2019

Summary

Checklist

For maintainers

elasticmachine commented Sep 16, 2019

spong Sep 16, 2019

Choose a reason for hiding this comment

FrankHassanabad Sep 17, 2019 • edited Loading

Choose a reason for hiding this comment

FrankHassanabad Sep 17, 2019

Choose a reason for hiding this comment

elasticmachine commented Sep 16, 2019

💚 Build Succeeded

FrankHassanabad left a comment

Choose a reason for hiding this comment

elasticmachine commented Sep 17, 2019

💚 Build Succeeded

elasticmachine commented Sep 17, 2019

💚 Build Succeeded

FrankHassanabad Sep 17, 2019 •

edited

Loading