-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console] Regenerate autocomplete definitions for 8.15 #193208
[Console] Regenerate autocomplete definitions for 8.15 #193208
Conversation
Pinging @elastic/kibana-management (Team:Kibana Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm, left one question I had while reviewing. Let me know what you think!
"patterns": [ | ||
"_ingest/geoip/database/{id}" | ||
], | ||
"documentation": "https://www.elastic.co/guide/en/elasticsearch/reference/master/TODO.html", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still not have docs for these API's (delete, get, put)? Wonder if we should still show the documentation link at all in that case since it points to a 404 page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, thanks! This is actually a typo in the Elasticsearch repo, I opened elastic/elasticsearch#113082 to fix it. To get it fixed here, the normal way is:
- fix it in Elasticsearch
- wait or trigger the daily sync to the Elasticsearch specification
- then run the Kibana generate_console_definitions.js script.
That's a lot! In the interest on not blocking this pull request, I have fixed the URLs in 5bc5c77
(#193208).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latest lgtm 🚀
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
## Summary This regenerates the autocomplete definitions using the current 8.15 branch of the Elasticsearch specification. More specifically: * Rename `query_rules` APIs to `query_ruleset` as was done in 8.15 (not sure why this was not applied already) * Update `format` for `esql.query` to include `arrow` (and remove the corresponding override) * Add three new Ingest GeoIP APIs and 3 Security APIs * Remove a number of unused/harmful query parameter overrides (cherry picked from commit e5299a5)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
#193283) # Backport This will backport the following commits from `main` to `8.x`: - [[Console] Regenerate autocomplete definitions for 8.15 (#193208)](#193208) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Quentin Pradet","email":"quentin.pradet@elastic.co"},"sourceCommit":{"committedDate":"2024-09-18T12:13:10Z","message":"[Console] Regenerate autocomplete definitions for 8.15 (#193208)\n\n## Summary\r\n\r\nThis regenerates the autocomplete definitions using the current 8.15\r\nbranch of the Elasticsearch specification. More specifically:\r\n\r\n* Rename `query_rules` APIs to `query_ruleset` as was done in 8.15 (not\r\nsure why this was not applied already)\r\n* Update `format` for `esql.query` to include `arrow` (and remove the\r\ncorresponding override)\r\n * Add three new Ingest GeoIP APIs and 3 Security APIs\r\n * Remove a number of unused/harmful query parameter overrides","sha":"e5299a562e6a5e5071bed69b422df549d990d578","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana Management","release_note:skip","v9.0.0","v8.16.0","backport:version","v8.15.2"],"title":"[Console] Regenerate autocomplete definitions for 8.15","number":193208,"url":"#193208 Regenerate autocomplete definitions for 8.15 (#193208)\n\n## Summary\r\n\r\nThis regenerates the autocomplete definitions using the current 8.15\r\nbranch of the Elasticsearch specification. More specifically:\r\n\r\n* Rename `query_rules` APIs to `query_ruleset` as was done in 8.15 (not\r\nsure why this was not applied already)\r\n* Update `format` for `esql.query` to include `arrow` (and remove the\r\ncorresponding override)\r\n * Add three new Ingest GeoIP APIs and 3 Security APIs\r\n * Remove a number of unused/harmful query parameter overrides","sha":"e5299a562e6a5e5071bed69b422df549d990d578"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"#193208 Regenerate autocomplete definitions for 8.15 (#193208)\n\n## Summary\r\n\r\nThis regenerates the autocomplete definitions using the current 8.15\r\nbranch of the Elasticsearch specification. More specifically:\r\n\r\n* Rename `query_rules` APIs to `query_ruleset` as was done in 8.15 (not\r\nsure why this was not applied already)\r\n* Update `format` for `esql.query` to include `arrow` (and remove the\r\ncorresponding override)\r\n * Add three new Ingest GeoIP APIs and 3 Security APIs\r\n * Remove a number of unused/harmful query parameter overrides","sha":"e5299a562e6a5e5071bed69b422df549d990d578"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
## Summary This regenerates the autocomplete definitions using the current 8.15 branch of the Elasticsearch specification. More specifically: * Rename `query_rules` APIs to `query_ruleset` as was done in 8.15 (not sure why this was not applied already) * Update `format` for `esql.query` to include `arrow` (and remove the corresponding override) * Add three new Ingest GeoIP APIs and 3 Security APIs * Remove a number of unused/harmful query parameter overrides
This regenerates the autocomplete definitions using the current 8.15 branch of the Elasticsearch specification. More specifically: * Rename `query_rules` APIs to `query_ruleset` as was done in 8.15 (not sure why this was not applied already) * Update `format` for `esql.query` to include `arrow` (and remove the corresponding override) * Add three new Ingest GeoIP APIs and 3 Security APIs * Remove a number of unused/harmful query parameter overrides (cherry picked from commit e5299a5)
Summary
This regenerates the autocomplete definitions using the current 8.15 branch of the Elasticsearch specification. More specifically:
query_rules
APIs toquery_ruleset
as was done in 8.15 (not sure why this was not applied already)format
foresql.query
to includearrow
(and remove the corresponding override)This screenshot shows that
arrow
is correctly included foresql.query
:For maintainers