Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Fleet] Add option to have Kafka dynamic topics in outputs (#192720) #193197

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…92720)

## Summary

Add option to have Kafka dynamic topics in outputs settings. It adds
selection with radio buttons under the `topic` section.

### UI changes

![Screenshot 2024-09-13 at 16 32
54](https://github.com/user-attachments/assets/9414f475-c115-4986-a204-eeb79471b7ea)
![Screenshot 2024-09-13 at 16 33
03](https://github.com/user-attachments/assets/ac36b1da-0e81-4f97-9632-ced8b5776af2)
![Screenshot 2024-09-13 at 16 33
12](https://github.com/user-attachments/assets/5ea3cf66-d929-45fb-aa3b-924734c34305)
![Screenshot 2024-09-13 at 16 33
40](https://github.com/user-attachments/assets/62e477c8-5719-41fe-94b1-4bdda0f00007)

<details>
  <summary>Testing</summary>

- Create a kafka output, fill the required fields, select "static" topic
and fill it out with "default_topic". Payload will be:
![Screenshot 2024-09-13 at 16 36
50](https://github.com/user-attachments/assets/ea3761b8-39cb-40ce-bf1c-85e3af1f9d4b)
- The output should be created correctly

- Create a kafka output, fill the required fields, select "dynamic"
topic and choose one from the dropdown. Payload will be:
![Screenshot 2024-09-13 at 16 36
23](https://github.com/user-attachments/assets/8d0d3ce4-5fb0-4c01-a939-b6a9d50da219)

- Create a kafka output, fill the required fields, select "dynamic"
topic and input one not present in the dropdown (I had "custom_topic".
Payload will be like this:
![Screenshot 2024-09-13 at 16 35
52](https://github.com/user-attachments/assets/27347d01-3efc-4c23-85a8-f3287854de4f)
</details>

- Try updating an existing Kafka output from one type to another, it
should work correctly

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit c0aaada)
@kibanamachine kibanamachine enabled auto-merge (squash) September 17, 2024 16:18
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Sep 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Fleet Cypress Tests #4 / View agents list Agent status filter should filter on healthy (16 result)
  • [job] [logs] Fleet Cypress Tests #4 / View agents list Agent status filter should filter on healthy and unhealthy
  • [job] [logs] Fleet Cypress Tests #4 / View agents list Bulk actions should allow to bulk upgrade agents and cancel that upgrade

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.8MB 1.8MB +2.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 170.1KB 171.1KB +1.0KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

@kibanamachine kibanamachine merged commit 513a12e into elastic:8.x Sep 17, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants