-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Embeddable Rebuild] [Controls] Clean up services + TODOs #193180
Merged
Heenawter
merged 14 commits into
elastic:main
from
Heenawter:embeddableRebuild_controls_cleanup-todos-and-services_2024-09-12
Sep 19, 2024
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3961b87
Refactor the services make use consistent
Heenawter 40c3c19
Address some of the `TODO`s
Heenawter 1b2a3e4
Delete `useAsync` TODOs
Heenawter 5f6f754
Set services ready
Heenawter 69cb7a2
Debounce range slider loading state
Heenawter d9b294a
Remove final `TODO`
Heenawter 7d4406c
Make compatibility checks async
Heenawter b87037e
[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'
kibanamachine 5241d8d
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine c71bfeb
Fix types + tests that use services
Heenawter 7b609b8
Fix timeslider registration to await new services
Heenawter 3cc39f7
Code review
Heenawter ded4bef
Re-add untilPluginStartServicesReady
Heenawter d4c4620
Merge branch 'main' into embeddableRebuild_controls_cleanup-todos-and…
Heenawter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
src/plugins/controls/public/actions/clear_control_action_compatibility_check.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the "Elastic License | ||
* 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side | ||
* Public License v 1"; you may not use this file except in compliance with, at | ||
* your election, the "Elastic License 2.0", the "GNU Affero General Public | ||
* License v3.0 only", or the "Server Side Public License, v 1". | ||
*/ | ||
|
||
import { PresentationContainer, apiIsPresentationContainer } from '@kbn/presentation-containers'; | ||
import { | ||
HasParentApi, | ||
HasType, | ||
HasUniqueId, | ||
apiCanAccessViewMode, | ||
apiHasParentApi, | ||
apiHasType, | ||
apiHasUniqueId, | ||
apiIsOfType, | ||
} from '@kbn/presentation-publishing'; | ||
import { CONTROL_GROUP_TYPE } from '../../common'; | ||
import { isClearableControl, type CanClearSelections } from '../types'; | ||
|
||
type ClearControlActionApi = HasType & | ||
HasUniqueId & | ||
CanClearSelections & | ||
HasParentApi<PresentationContainer & HasType>; | ||
|
||
export const compatibilityCheck = (api: unknown | null): api is ClearControlActionApi => | ||
Boolean( | ||
apiHasType(api) && | ||
apiHasUniqueId(api) && | ||
isClearableControl(api) && | ||
apiHasParentApi(api) && | ||
apiCanAccessViewMode(api.parentApi) && | ||
apiIsOfType(api.parentApi, CONTROL_GROUP_TYPE) && | ||
apiIsPresentationContainer(api.parentApi) | ||
); | ||
|
||
export function isCompatible(api: unknown) { | ||
return compatibilityCheck(api); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After #192017, this was not actually used - so removing it now.