Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embeddable Rebuild] [Controls] Clean up services + TODOs #193180

Merged
merged 14 commits into from
Sep 19, 2024
Merged

[Embeddable Rebuild] [Controls] Clean up services + TODOs #193180

merged 14 commits into from
Sep 19, 2024

Commits on Sep 17, 2024

  1. Refactor the services make use consistent

    @Heenawter
    Heenawter committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    3961b87 View commit details
    Browse the repository at this point in the history

  2. Address some of the TODOs

    @Heenawter
    Heenawter committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    40c3c19 View commit details
    Browse the repository at this point in the history

  3. Delete useAsync TODOs

    @Heenawter
    Heenawter committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    1b2a3e4 View commit details
    Browse the repository at this point in the history

  4. Set services ready

    @Heenawter
    Heenawter committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5f6f754 View commit details
    Browse the repository at this point in the history

  5. Debounce range slider loading state

    @Heenawter
    Heenawter committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    69cb7a2 View commit details
    Browse the repository at this point in the history

  6. Remove final TODO

    @Heenawter
    Heenawter committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d9b294a View commit details
    Browse the repository at this point in the history

  7. Make compatibility checks async

    @Heenawter
    Heenawter committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    7d4406c View commit details
    Browse the repository at this point in the history

  8. [CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'

    @kibanamachine
    kibanamachine committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    b87037e View commit details
    Browse the repository at this point in the history

  9. [CI] Auto-commit changed files from 'node scripts/eslint --no-cache -… 

    …-fix'
    @kibanamachine
    kibanamachine committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5241d8d View commit details
    Browse the repository at this point in the history

  10. Fix types + tests that use services

    @Heenawter
    Heenawter committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    c71bfeb View commit details
    Browse the repository at this point in the history

  11. Fix timeslider registration to await new services

    @Heenawter
    Heenawter committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    7b609b8 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Code review

    @Heenawter
    Heenawter committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3cc39f7 View commit details
    Browse the repository at this point in the history

  2. Re-add untilPluginStartServicesReady

    @Heenawter
    Heenawter committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ded4bef View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into embeddableRebuild_controls_cleanup-todos-and… 

    …-services_2024-09-12
    @Heenawter
    Heenawter committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d4c4620 View commit details
    Browse the repository at this point in the history