Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] [Attack discovery] Updates Gemini connector to ignore unknown properties in responses #192915

Commits on Sep 13, 2024

  1. ## [Security Solution] [Attack discovery] Updates Gemini connector to…

    … ignore unknown properties in responses
    
    ### Summary
    
    This PR updates the Gemini connector's `RunApiResponseSchema` to ignore unknown properties in responses.
    
    It fixes an issue where the recent addition of a `modelVersion` in Gemini responses causes Attack discovery to fail with the following error:
    
    ```
    Attack discovery generation failed
    
    ActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing)
    ```
    
    shown in the screenshot below:
    
    ![error](https://github.com/user-attachments/assets/8b706290-27ca-42d9-b972-3d8613af690c)
    
    ### Desk testing
    
    To reproduce:
    
    1) Navigate to Security > Attack discovery
    
    2) Select a Gemini connector
    
    3) Click Generate
    
    **Expected result**
    
    - Attack discoveries are generated
    
    **Actual result**
    
    - The following error is displayed:
    
    ```
    Attack discovery generation failed
    
    ActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing)
    ```
    
    ![error](https://github.com/user-attachments/assets/8b706290-27ca-42d9-b972-3d8613af690c)
    andrew-goldstein committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b8b77da View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Configuration menu
    Copy the full SHA
    bc628e9 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Configuration menu
    Copy the full SHA
    8f9c96f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c2d4176 View commit details
    Browse the repository at this point in the history