[Security Solution] [Attack discovery] Updates Gemini connector to ignore unknown properties in responses #192915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ignore unknown properties in responses ### Summary This PR updates the Gemini connector's `RunApiResponseSchema` to ignore unknown properties in responses. It fixes an issue where the recent addition of a `modelVersion` in Gemini responses causes Attack discovery to fail with the following error: ``` Attack discovery generation failed ActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing) ``` shown in the screenshot below:  ### Desk testing To reproduce: 1) Navigate to Security > Attack discovery 2) Select a Gemini connector 3) Click Generate **Expected result** - Attack discoveries are generated **Actual result** - The following error is displayed: ``` Attack discovery generation failed ActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing) ``` 
andrew-goldstein
added
bug
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Files by Code Ownerelastic/appex-ai-infra
elastic/obs-ai-assistant
elastic/response-ops
elastic/security-generative-ai
|
neptunian
approved these changes
Sep 13, 2024
stephmilovic
approved these changes
Sep 13, 2024
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
pgayvallet
approved these changes
Sep 17, 2024
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
andrew-goldstein
deleted the
ignore_uknowns_in_gemini_response_schema
branch
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 17, 2024
…nore unknown properties in responses (elastic#192915) ## [Security Solution] [Attack discovery] Updates Gemini connector to ignore unknown properties in responses ### Summary This PR updates the Gemini connector's `RunApiResponseSchema` to ignore unknown properties in responses. It fixes an issue where the recent addition of a `modelVersion` in Gemini responses causes Attack discovery to fail with the following error: ``` Attack discovery generation failed ActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing) ``` shown in the screenshot below:  ### Desk testing To reproduce: 1) Navigate to Security > Attack discovery 2) Select a Gemini connector 3) Click Generate **Expected result** - Attack discoveries are generated **Actual result** - The following error is displayed: ``` Attack discovery generation failed ActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing) ```  (cherry picked from commit 699db81)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 17, 2024
…nore unknown properties in responses (elastic#192915) ## [Security Solution] [Attack discovery] Updates Gemini connector to ignore unknown properties in responses ### Summary This PR updates the Gemini connector's `RunApiResponseSchema` to ignore unknown properties in responses. It fixes an issue where the recent addition of a `modelVersion` in Gemini responses causes Attack discovery to fail with the following error: ``` Attack discovery generation failed ActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing) ``` shown in the screenshot below:  ### Desk testing To reproduce: 1) Navigate to Security > Attack discovery 2) Select a Gemini connector 3) Click Generate **Expected result** - Attack discoveries are generated **Actual result** - The following error is displayed: ``` Attack discovery generation failed ActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing) ```  (cherry picked from commit 699db81)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 17, 2024
…r to ignore unknown properties in responses (#192915) (#193221) # Backport This will backport the following commits from `main` to `8.15`: - [[Security Solution] [Attack discovery] Updates Gemini connector to ignore unknown properties in responses (#192915)](#192915) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Andrew Macri","email":"andrew.macri@elastic.co"},"sourceCommit":{"committedDate":"2024-09-17T19:46:48Z","message":"[Security Solution] [Attack discovery] Updates Gemini connector to ignore unknown properties in responses (#192915)\n\n## [Security Solution] [Attack discovery] Updates Gemini connector to ignore unknown properties in responses\r\n\r\n### Summary\r\n\r\nThis PR updates the Gemini connector's `RunApiResponseSchema` to ignore unknown properties in responses.\r\n\r\nIt fixes an issue where the recent addition of a `modelVersion` in Gemini responses causes Attack discovery to fail with the following error:\r\n\r\n```\r\nAttack discovery generation failed\r\n\r\nActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing)\r\n```\r\n\r\nshown in the screenshot below:\r\n\r\n\r\n\r\n### Desk testing\r\n\r\nTo reproduce:\r\n\r\n1) Navigate to Security > Attack discovery\r\n\r\n2) Select a Gemini connector\r\n\r\n3) Click Generate\r\n\r\n**Expected result**\r\n\r\n- Attack discoveries are generated\r\n\r\n**Actual result**\r\n\r\n- The following error is displayed:\r\n\r\n```\r\nAttack discovery generation failed\r\n\r\nActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing)\r\n```\r\n\r\n","sha":"699db81856eaf9a3666f4f46fa58ee4619b3b17c","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","v8.16.0","v8.15.2"],"title":"[Security Solution] [Attack discovery] Updates Gemini connector to ignore unknown properties in responses","number":192915,"url":"#192915 Solution] [Attack discovery] Updates Gemini connector to ignore unknown properties in responses (#192915)\n\n## [Security Solution] [Attack discovery] Updates Gemini connector to ignore unknown properties in responses\r\n\r\n### Summary\r\n\r\nThis PR updates the Gemini connector's `RunApiResponseSchema` to ignore unknown properties in responses.\r\n\r\nIt fixes an issue where the recent addition of a `modelVersion` in Gemini responses causes Attack discovery to fail with the following error:\r\n\r\n```\r\nAttack discovery generation failed\r\n\r\nActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing)\r\n```\r\n\r\nshown in the screenshot below:\r\n\r\n\r\n\r\n### Desk testing\r\n\r\nTo reproduce:\r\n\r\n1) Navigate to Security > Attack discovery\r\n\r\n2) Select a Gemini connector\r\n\r\n3) Click Generate\r\n\r\n**Expected result**\r\n\r\n- Attack discoveries are generated\r\n\r\n**Actual result**\r\n\r\n- The following error is displayed:\r\n\r\n```\r\nAttack discovery generation failed\r\n\r\nActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing)\r\n```\r\n\r\n\n\n## [Security Solution] [Attack discovery] Updates Gemini connector to ignore unknown properties in responses\r\n\r\n### Summary\r\n\r\nThis PR updates the Gemini connector's `RunApiResponseSchema` to ignore unknown properties in responses.\r\n\r\nIt fixes an issue where the recent addition of a `modelVersion` in Gemini responses causes Attack discovery to fail with the following error:\r\n\r\n```\r\nAttack discovery generation failed\r\n\r\nActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing)\r\n```\r\n\r\nshown in the screenshot below:\r\n\r\n\r\n\r\n### Desk testing\r\n\r\nTo reproduce:\r\n\r\n1) Navigate to Security > Attack discovery\r\n\r\n2) Select a Gemini connector\r\n\r\n3) Click Generate\r\n\r\n**Expected result**\r\n\r\n- Attack discoveries are generated\r\n\r\n**Actual result**\r\n\r\n- The following error is displayed:\r\n\r\n```\r\nAttack discovery generation failed\r\n\r\nActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing)\r\n```\r\n\r\n","sha":"699db81856eaf9a3666f4f46fa58ee4619b3b17c"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Andrew Macri <andrew.macri@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Sep 17, 2024
… to ignore unknown properties in responses (#192915) (#193222) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] [Attack discovery] Updates Gemini connector to ignore unknown properties in responses (#192915)](#192915) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Andrew Macri","email":"andrew.macri@elastic.co"},"sourceCommit":{"committedDate":"2024-09-17T19:46:48Z","message":"[Security Solution] [Attack discovery] Updates Gemini connector to ignore unknown properties in responses (#192915)\n\n## [Security Solution] [Attack discovery] Updates Gemini connector to ignore unknown properties in responses\r\n\r\n### Summary\r\n\r\nThis PR updates the Gemini connector's `RunApiResponseSchema` to ignore unknown properties in responses.\r\n\r\nIt fixes an issue where the recent addition of a `modelVersion` in Gemini responses causes Attack discovery to fail with the following error:\r\n\r\n```\r\nAttack discovery generation failed\r\n\r\nActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing)\r\n```\r\n\r\nshown in the screenshot below:\r\n\r\n\r\n\r\n### Desk testing\r\n\r\nTo reproduce:\r\n\r\n1) Navigate to Security > Attack discovery\r\n\r\n2) Select a Gemini connector\r\n\r\n3) Click Generate\r\n\r\n**Expected result**\r\n\r\n- Attack discoveries are generated\r\n\r\n**Actual result**\r\n\r\n- The following error is displayed:\r\n\r\n```\r\nAttack discovery generation failed\r\n\r\nActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing)\r\n```\r\n\r\n","sha":"699db81856eaf9a3666f4f46fa58ee4619b3b17c","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","v8.16.0","v8.15.2"],"title":"[Security Solution] [Attack discovery] Updates Gemini connector to ignore unknown properties in responses","number":192915,"url":"#192915 Solution] [Attack discovery] Updates Gemini connector to ignore unknown properties in responses (#192915)\n\n## [Security Solution] [Attack discovery] Updates Gemini connector to ignore unknown properties in responses\r\n\r\n### Summary\r\n\r\nThis PR updates the Gemini connector's `RunApiResponseSchema` to ignore unknown properties in responses.\r\n\r\nIt fixes an issue where the recent addition of a `modelVersion` in Gemini responses causes Attack discovery to fail with the following error:\r\n\r\n```\r\nAttack discovery generation failed\r\n\r\nActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing)\r\n```\r\n\r\nshown in the screenshot below:\r\n\r\n\r\n\r\n### Desk testing\r\n\r\nTo reproduce:\r\n\r\n1) Navigate to Security > Attack discovery\r\n\r\n2) Select a Gemini connector\r\n\r\n3) Click Generate\r\n\r\n**Expected result**\r\n\r\n- Attack discoveries are generated\r\n\r\n**Actual result**\r\n\r\n- The following error is displayed:\r\n\r\n```\r\nAttack discovery generation failed\r\n\r\nActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing)\r\n```\r\n\r\n\n\n## [Security Solution] [Attack discovery] Updates Gemini connector to ignore unknown properties in responses\r\n\r\n### Summary\r\n\r\nThis PR updates the Gemini connector's `RunApiResponseSchema` to ignore unknown properties in responses.\r\n\r\nIt fixes an issue where the recent addition of a `modelVersion` in Gemini responses causes Attack discovery to fail with the following error:\r\n\r\n```\r\nAttack discovery generation failed\r\n\r\nActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing)\r\n```\r\n\r\nshown in the screenshot below:\r\n\r\n\r\n\r\n### Desk testing\r\n\r\nTo reproduce:\r\n\r\n1) Navigate to Security > Attack discovery\r\n\r\n2) Select a Gemini connector\r\n\r\n3) Click Generate\r\n\r\n**Expected result**\r\n\r\n- Attack discoveries are generated\r\n\r\n**Actual result**\r\n\r\n- The following error is displayed:\r\n\r\n```\r\nAttack discovery generation failed\r\n\r\nActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing)\r\n```\r\n\r\n","sha":"699db81856eaf9a3666f4f46fa58ee4619b3b17c"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Andrew Macri <andrew.macri@elastic.co>
markov00
pushed a commit
to markov00/kibana
that referenced
this pull request
Sep 18, 2024
…nore unknown properties in responses (elastic#192915) ## [Security Solution] [Attack discovery] Updates Gemini connector to ignore unknown properties in responses ### Summary This PR updates the Gemini connector's `RunApiResponseSchema` to ignore unknown properties in responses. It fixes an issue where the recent addition of a `modelVersion` in Gemini responses causes Attack discovery to fail with the following error: ``` Attack discovery generation failed ActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing) ``` shown in the screenshot below:  ### Desk testing To reproduce: 1) Navigate to Security > Attack discovery 2) Select a Gemini connector 3) Click Generate **Expected result** - Attack discoveries are generated **Actual result** - The following error is displayed: ``` Attack discovery generation failed ActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing) ``` 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Security Solution] [Attack discovery] Updates Gemini connector to ignore unknown properties in responses
Summary
This PR updates the Gemini connector's
RunApiResponseSchemato ignore unknown properties in responses.It fixes an issue where the recent addition of a
modelVersionin Gemini responses causes Attack discovery to fail with the following error:shown in the screenshot below:
Desk testing
To reproduce:
Navigate to Security > Attack discovery
Select a Gemini connector
Click Generate
Expected result
Actual result