-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security GenAI] Re-add telemetry for isEnabledKnowledgeBase
#192785
Conversation
Pinging @elastic/security-solution (Team: SecuritySolution) |
x-pack/plugins/elastic_assistant/server/routes/post_actions_connector_execute.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM! Left a couple notes about a slight difference between client/server checks and a conflict we'll see when backporting to 8.15.2
, but overall everything looks 👍 to me.
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
…ic#192785) (cherry picked from commit cabaf7a)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
…ic#192785) (cherry picked from commit cabaf7a) # Conflicts: # x-pack/packages/kbn-elastic-assistant/impl/assistant/chat_send/use_chat_send.tsx # x-pack/plugins/elastic_assistant/server/routes/helpers.ts # x-pack/plugins/elastic_assistant/server/routes/post_actions_connector_execute.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…ase` (#192785) (#192937) # Backport This will backport the following commits from `main` to `8.x`: - [[Security GenAI] Re-add telemetry for `isEnabledKnowledgeBase` (#192785)](#192785) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2024-09-13T23:17:08Z","message":"[Security GenAI] Re-add telemetry for `isEnabledKnowledgeBase` (#192785)","sha":"cabaf7a0774cda8775c059c36b7db7679ca19d8a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","v8.16.0","v8.15.2"],"title":"[Security GenAI] Re-add telemetry for `isEnabledKnowledgeBase`","number":192785,"url":"#192785 GenAI] Re-add telemetry for `isEnabledKnowledgeBase` (#192785)","sha":"cabaf7a0774cda8775c059c36b7db7679ca19d8a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"#192785 GenAI] Re-add telemetry for `isEnabledKnowledgeBase` (#192785)","sha":"cabaf7a0774cda8775c059c36b7db7679ca19d8a"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
…#192785) (#192938) # Backport This will backport the following commits from `main` to `8.15`: - [[Security GenAI] Re-add telemetry for `isEnabledKnowledgeBase` (#192785)](#192785) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2024-09-13T23:17:08Z","message":"[Security GenAI] Re-add telemetry for `isEnabledKnowledgeBase` (#192785)","sha":"cabaf7a0774cda8775c059c36b7db7679ca19d8a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","v8.16.0","v8.15.2"],"number":192785,"url":"#192785 GenAI] Re-add telemetry for `isEnabledKnowledgeBase` (#192785)","sha":"cabaf7a0774cda8775c059c36b7db7679ca19d8a"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"#192785 GenAI] Re-add telemetry for `isEnabledKnowledgeBase` (#192785)","sha":"cabaf7a0774cda8775c059c36b7db7679ca19d8a"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"url":"#192937"}]}] BACKPORT--> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Summary
isEnabledKnowledgeBase
was removed from the browser side eventAssistant Message Sent
and the server side eventsinvoke_assistant_success
/invoke_assistant_error
. When we originally merged the KB work, we were under the impression KB would be installed by default. At the last minute in 8.15 release cycle, it was decided that enabling it automatically can have cost concerns, so we opted for the button. We forgot to go back and re-add the isEnabledKnowledgeBase property. This PR addresses that.