-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Response Ops][Alerting] Only load maintenance windows when there are alerts during rule execution and caching loaded maintenance windows #192573
Merged
ymao1
merged 22 commits into
elastic:main
from
ymao1:alerting/load-maintenance-windows-later
Sep 26, 2024
+1,619
−634
Merged
Changes from 16 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
a544490
Only loading maintenance windows if there are new alerts to persist
ymao1 6f71723
Fixing types
ymao1 71b7538
Need to load when there are any alerts not just new
ymao1 e097e99
Merging in main
ymao1 8d82191
Need to load when there are any alerts not just new
ymao1 3ef5f22
Merging in main
ymao1 9a5f463
wip
ymao1 9293e37
Caching maintenance windows
ymao1 c5af98f
Fixing tests
ymao1 cbb7c82
Fixing types
ymao1 18f8e10
Merge branch 'main' of github.com:elastic/kibana into alerting/load-m…
ymao1 1b98138
Taking cache interval into account when querying for maintenance windows
ymao1 2044596
Merge branch 'main' of github.com:elastic/kibana into alerting/load-m…
ymao1 57fd492
Merge branch 'main' into alerting/load-maintenance-windows-later
elasticmachine 3dd0eac
[CI] Auto-commit changed files from 'yarn openapi:bundle'
kibanamachine fc94013
Merge branch 'main' into alerting/load-maintenance-windows-later
elasticmachine 46e48cf
Fixing test
ymao1 99556c2
Merge branch 'main' of github.com:elastic/kibana into alerting/load-m…
ymao1 5e3d400
Merge branch 'main' into alerting/load-maintenance-windows-later
elasticmachine 120df74
Merge branch 'main' of github.com:elastic/kibana into alerting/load-m…
ymao1 883d909
PR feedback
ymao1 3e43f91
Merge branch 'main' into alerting/load-maintenance-windows-later
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
217 changes: 183 additions & 34 deletions
217
x-pack/plugins/alerting/server/alerts_client/alerts_client.test.ts
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
complete aside, but if the occaisonal event loop delays we seen in rules are caused by
processAlerts()
, making this async may help - chunks things up a bit, give other node events get a chance to run