-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.17] fix archive path for chromium download (#191953) #192001
Merged
kibanamachine
merged 3 commits into
elastic:7.17
from
kibanamachine:backport/7.17/pr-191953
Sep 3, 2024
Merged
[7.17] fix archive path for chromium download (#191953) #192001
kibanamachine
merged 3 commits into
elastic:7.17
from
kibanamachine:backport/7.17/pr-191953
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary This PR is a follow up to the work that's been done to make it relatively straight forward to backport puppeteer updates to the 7.17 branch in elastic#188390. This change ensures the archive path for chromium doesn't get installed outside of the kibana directory, the previous expression resulted in an archive path outside of the kibana directory which unfortunately could result in a resolution of a path that kibana has no permissions to write to, depending on where kibana is being executed from. ## How to test - Pull this PR and delete the `.chromium` directory, for whatever platform this PR is is been tested on we should get no errors about installing the chromium and we should see the appropriate chromium archive for the os platform available in the `.chromium` that would get created. <!-- ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --> (cherry picked from commit 4bf2f97)
/ci |
eokoneyo
force-pushed
the
backport/7.17/pr-191953
branch
from
September 3, 2024 17:07
b1067b4
to
b1b94a9
Compare
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @eokoneyo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
main
to7.17
:Questions ?
Please refer to the Backport tool documentation
","sha":"4bf2f97451315b49cf9b73abf5c0e111581cd711","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:SharedUX","backport:prev-major","v8.16.0","Feature:Reporting:Framework"],"title":"fix archive path for chromium download","number":191953,"url":"https://github.com//pull/191953","mergeCommit":{"message":"fix archive path for chromium download (#191953)\n\n## Summary\r\n\r\nThis PR is a follow up to the work that's been done to make it\r\nrelatively straight forward to backport puppeteer updates to the 7.17\r\nbranch in https://github.com//pull/188390.\r\n\r\nThis change ensures the archive path for chromium doesn't get installed\r\noutside of the kibana directory, the previous expression resulted in an\r\narchive path outside of the kibana directory which unfortunately could\r\nresult in a resolution of a path that kibana has no permissions to write\r\nto, depending on where kibana is being executed from.\r\n\r\n## How to test\r\n \r\n- Pull this PR and delete the `.chromium` directory, for whatever\r\nplatform this PR is is been tested on we should get no errors about\r\ninstalling the chromium and we should see the appropriate chromium\r\narchive for the os platform available in the `.chromium` that would get\r\ncreated.\r\n\r\n\r\n","sha":"4bf2f97451315b49cf9b73abf5c0e111581cd711"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com//pull/191953","number":191953,"mergeCommit":{"message":"fix archive path for chromium download (#191953)\n\n## Summary\r\n\r\nThis PR is a follow up to the work that's been done to make it\r\nrelatively straight forward to backport puppeteer updates to the 7.17\r\nbranch in https://github.com//pull/188390.\r\n\r\nThis change ensures the archive path for chromium doesn't get installed\r\noutside of the kibana directory, the previous expression resulted in an\r\narchive path outside of the kibana directory which unfortunately could\r\nresult in a resolution of a path that kibana has no permissions to write\r\nto, depending on where kibana is being executed from.\r\n\r\n## How to test\r\n \r\n- Pull this PR and delete the `.chromium` directory, for whatever\r\nplatform this PR is is been tested on we should get no errors about\r\ninstalling the chromium and we should see the appropriate chromium\r\narchive for the os platform available in the `.chromium` that would get\r\ncreated.\r\n\r\n\r\n","sha":"4bf2f97451315b49cf9b73abf5c0e111581cd711"}}]}] BACKPORT-->