-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Synthetics installMissingPackage during monitor cruds #191486
Conversation
/ci |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
/ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pinging @elastic/fleet (Team:Fleet) |
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
@shahzad31 - Please try to include more content in PR descriptions. A relevant issue to reference, steps to reproduce, and a summary of the changes would be great to help with productive code review. The PR template for Kibana should have some helpful starting points for this. |
We are trying to invetigate all the code paths our project monitor API was interacting and after checking APM trace, found multiple API calls which seems excessive while interacting with fleet. I think this is mostly code refactoring category i would say. it's related to this SDH https://github.com/elastic/sdh-synthetics/issues/120 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but think a variable naming change might be good.
...olution/synthetics/server/synthetics_service/private_location/synthetics_private_location.ts
Outdated
Show resolved
Hide resolved
@shahzad31 what is the status of this PR? |
74c2219
to
ca09a53
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
History
To update your PR or re-run it, just comment with: |
## Summary Reuse package infos for synthetics bulk ops !! We are just trying to debug Project monitor push API which interacts with fleet code and trying to see what excessive calls are being made, which can be reduced. (cherry picked from commit 6d584d4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…193846) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Reuse package infos for synthetics bulk ops (#191486)](#191486) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-09-24T10:33:22Z","message":"[Fleet] Reuse package infos for synthetics bulk ops (#191486)\n\n## Summary\r\n\r\n Reuse package infos for synthetics bulk ops !!\r\n\r\nWe are just trying to debug Project monitor push API which interacts\r\nwith fleet code and trying to see what excessive calls are being made,\r\nwhich can be reduced.","sha":"6d584d49a73284077d5331c9c5398593f9edd5ea","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Fleet] Reuse package infos for synthetics bulk ops","number":191486,"url":"#191486 Reuse package infos for synthetics bulk ops (#191486)\n\n## Summary\r\n\r\n Reuse package infos for synthetics bulk ops !!\r\n\r\nWe are just trying to debug Project monitor push API which interacts\r\nwith fleet code and trying to see what excessive calls are being made,\r\nwhich can be reduced.","sha":"6d584d49a73284077d5331c9c5398593f9edd5ea"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"#191486 Reuse package infos for synthetics bulk ops (#191486)\n\n## Summary\r\n\r\n Reuse package infos for synthetics bulk ops !!\r\n\r\nWe are just trying to debug Project monitor push API which interacts\r\nwith fleet code and trying to see what excessive calls are being made,\r\nwhich can be reduced.","sha":"6d584d49a73284077d5331c9c5398593f9edd5ea"}}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
Summary
Reuse package infos for synthetics bulk ops !!
We are just trying to debug Project monitor push API which interacts with fleet code and trying to see what excessive calls are being made, which can be reduced.