-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Ensure install package during buildPackagePolicyFromPackage #190413
Conversation
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, it would be good to cover with tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it will break the current behavior that uninstall a package if the package was not installed before the package policy creation
@nchaulet The uninstall only happens if there was an error creating the package policy and the package was not installed before, why is that an issue? kibana/x-pack/plugins/fleet/server/routes/package_policy/handlers.ts Lines 302 to 322 in 8266415
|
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
closing in favour of #191486 |
Summary
Ensure install package during buildPackagePolicyFromPackage !!