-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Prevent skippable changes pr break #188740
Merged
delanni
merged 7 commits into
elastic:main
from
delanni:prevent-skippable-changes-pr-break
Jul 22, 2024
Merged
[CI] Prevent skippable changes pr break #188740
delanni
merged 7 commits into
elastic:main
from
delanni:prevent-skippable-changes-pr-break
Jul 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/ci |
/ci |
1 similar comment
/ci |
delanni
force-pushed
the
prevent-skippable-changes-pr-break
branch
from
July 19, 2024 15:02
dc31ce6
to
1d24a39
Compare
/ci |
1 similar comment
/ci |
delanni
force-pushed
the
prevent-skippable-changes-pr-break
branch
from
July 19, 2024 15:19
1d24a39
to
5df235a
Compare
/ci |
💚 Build Succeeded
History
|
delanni
added
release_note:skip
Skip the PR/issue when compiling release notes
backport:all-open
Backport to all branches that could still receive a release
Team:Operations
Team label for Operations Team
labels
Jul 19, 2024
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
reviewed
Jul 19, 2024
jbudz
reviewed
Jul 19, 2024
delanni
force-pushed
the
prevent-skippable-changes-pr-break
branch
3 times, most recently
from
July 20, 2024 10:18
8377ad9
to
668ebc0
Compare
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
Jul 22, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 22, 2024
## Summary Closes: elastic/kibana-operations#159 (cherry picked from commit 03148d2)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 22, 2024
# Backport This will backport the following commits from `main` to `8.15`: - [[CI] Prevent skippable changes pr break (#188740)](#188740) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2024-07-22T13:32:53Z","message":"[CI] Prevent skippable changes pr break (#188740)\n\n## Summary\r\nCloses: elastic/kibana-operations#159 Prevent skippable changes pr break","number":188740,"url":"#188740 Prevent skippable changes pr break (#188740)\n\n## Summary\r\nCloses: elastic/kibana-operations#159 Prevent skippable changes pr break (#188740)\n\n## Summary\r\nCloses: elastic/kibana-operations#159"}}]}] BACKPORT--> Co-authored-by: Alex Szabo <alex.szabo@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:all-open
Backport to all branches that could still receive a release
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
v8.15.0
v8.16.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On the new buildkite infra, anything emitted to stdout would be interpreted as Buildkite steps. The case where we don't want to run the CI would log something that crashes the PR pipeline. This PR emits an empty step, so the pipeline succeeds.
Closes: https://github.com/elastic/kibana-operations/issues/159