Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Prevent skippable changes pr break #188740

Merged
merged 7 commits into from
Jul 22, 2024

Conversation

delanni
Copy link
Contributor

@delanni delanni commented Jul 19, 2024

Summary

On the new buildkite infra, anything emitted to stdout would be interpreted as Buildkite steps. The case where we don't want to run the CI would log something that crashes the PR pipeline. This PR emits an empty step, so the pipeline succeeds.

Closes: https://github.com/elastic/kibana-operations/issues/159

@delanni
Copy link
Contributor Author

delanni commented Jul 19, 2024

/ci

@delanni
Copy link
Contributor Author

delanni commented Jul 19, 2024

/ci

1 similar comment
@delanni
Copy link
Contributor Author

delanni commented Jul 19, 2024

/ci

@delanni delanni force-pushed the prevent-skippable-changes-pr-break branch from dc31ce6 to 1d24a39 Compare July 19, 2024 15:02
@delanni
Copy link
Contributor Author

delanni commented Jul 19, 2024

/ci

1 similar comment
@delanni
Copy link
Contributor Author

delanni commented Jul 19, 2024

/ci

@delanni delanni force-pushed the prevent-skippable-changes-pr-break branch from 1d24a39 to 5df235a Compare July 19, 2024 15:19
@delanni
Copy link
Contributor Author

delanni commented Jul 19, 2024

/ci

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

@delanni delanni marked this pull request as ready for review July 19, 2024 16:36
@delanni delanni requested a review from a team as a code owner July 19, 2024 16:36
@delanni delanni added release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release Team:Operations Team label for Operations Team labels Jul 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@delanni delanni force-pushed the prevent-skippable-changes-pr-break branch 3 times, most recently from 8377ad9 to 668ebc0 Compare July 20, 2024 10:18
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@delanni delanni merged commit 03148d2 into elastic:main Jul 22, 2024
19 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 22, 2024
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 188740

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 22, 2024
# Backport

This will backport the following commits from `main` to `8.15`:
- [[CI] Prevent skippable changes pr break
(#188740)](#188740)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alex
Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2024-07-22T13:32:53Z","message":"[CI]
Prevent skippable changes pr break (#188740)\n\n## Summary\r\nCloses:
elastic/kibana-operations#159
Prevent skippable changes pr
break","number":188740,"url":"#188740
Prevent skippable changes pr break (#188740)\n\n## Summary\r\nCloses:
elastic/kibana-operations#159
Prevent skippable changes pr break (#188740)\n\n## Summary\r\nCloses:
elastic/kibana-operations#159"}}]}]
BACKPORT-->

Co-authored-by: Alex Szabo <alex.szabo@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.15.0 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants