[Spaces] Add warning for changes that impact other users

[sebelga]

In this PR I've added a warning callout on top of the "Save" button to warn for changes that will impact other users.

The callout renders when:

• editing an existing space (not on creation)
• changing any of the "features" toggles
• changing the solution view (but not if changing from undefined to classic)

Fixes https://github.com/elastic/platform-ux-team/issues/322

Screenshot

[sebelga]

/ci

[elasticmachine]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: c734f63

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
spaces	180.6KB	181.6KB	+1.0KB

cc @sebelga

[ek-so]

Thank you, I like the solution!
I'm wondering:

• Maybe we can say it a bit shorter, and right in the callout header?
• Shouldn't we also mention that the page will be reloaded? I've seen it was there in the modal before.
  cc. @kevinsweet

[sebelga]

Shouldn't we also mention that the page will be reloaded?

The page does not always reload. Only if the user is editing the current active space. For that we still have the modal that warns the user before saving.

[sebelga]

Maybe we can say it a bit shorter, and right in the callout header?

I think it is good to have both a title and a description. Open to suggestion for both copy texts 👍

[ek-so]

The page does not always reload. Only if the user is editing the current active space. For that we still have the modal that warns the user before saving.

Oh, right, thanks! Then I agree we can leave Warning + text below.

But my idea was to get rid of modal entirely (because showing modal only to say that the page will reload seems too much). So how about this — we show callout instead of modal, but with 2 alternate texts (depending on whether it's current space or not):

• Warning. The changes will impact all users in the space.
• Warning. The changes will impact all users in the space. After update, this page will be reloaded.

What do you think @sebelga?

[sebelga]

What do you think @sebelga?

I don't feel confident making decision for the security team.
As they own the space UI I think it would be best for them to decide what is best here.

cc @legrego @petrklapka

[elasticmachine]

Pinging @elastic/appex-sharedux (Team:SharedUX)

[elasticmachine]

Pinging @elastic/kibana-security (Team:Security)

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 7e1a031

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
spaces	180.6KB	181.7KB	+1.0KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sebelga

[petrklapka]

@ek-so @legrego - Let's go with @sebelga simple change for now. It does what is needed. We don't need to reinvent the wheel. I don't want to add noise to the overall effort which is significant. If this UX isn't ideal, we can iterate.

[SiddharthMantri]

Code changes LGTM! I've asked the team for their opinion on the modal. Happy to have this merged with a separate issue to remove/modify the modal.

[sebelga]

Thanks for the review @SiddharthMantri !

[legrego]

Sorry for the delay, I was on PTO. I'm fine with the approach taken here.