Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Multi-line string fields diff algorithm test plan #188323

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

dplumlee
Copy link
Contributor

Summary

Related ticket: #180159

Adds test plan for diff algorithm for arrays of scalar values implemented in #188022

For maintainers

@dplumlee dplumlee added release_note:skip Skip the PR/issue when compiling release notes test-plan Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules v8.16.0 labels Jul 15, 2024
@dplumlee dplumlee self-assigned this Jul 15, 2024
@dplumlee dplumlee requested a review from a team as a code owner July 15, 2024 16:07
@dplumlee dplumlee requested a review from xcrzx July 15, 2024 16:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@xcrzx xcrzx requested review from jpdjere and removed request for xcrzx July 16, 2024 10:49
Copy link
Contributor

@jpdjere jpdjere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@dplumlee dplumlee merged commit a9db600 into elastic:main Jul 23, 2024
7 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 23, 2024
@dplumlee dplumlee deleted the multi-line-string-diff-test-plan branch July 23, 2024 15:18
dplumlee added a commit that referenced this pull request Jul 26, 2024
…f algorithm (#188688)

## Summary

Completes #180159

Switches fields to use the multi line string diff algorithm assigned to
them in the [overarching
ticket](#180159 (comment))

Adds integration tests in accordance to
#188323 for the `upgrade/_review`
API endpoint for the multi line string field diff algorithm.


### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test-plan v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants