Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] added check for Enterprise license in package policy create/update APIs #187467

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented Jul 3, 2024

Summary

Relates https://github.com/elastic/ingest-dev/issues/3464

Added check to reject integration policy shared by multiple agent policies if Enterprise license is not available.

Testing

  • Enable a local enterprise licence (steps)
  • Enable flag enableReusableIntegrationPolicies
  • Try create/update package policy API with multiple policy_ids, expect to work

Repeat the steps with any lower licence, the API should reject the request with a 400 error.

POST kbn:/api/fleet/package_policies
{
  "policy_ids": [
    "policy-1", "policy-2"
  ],
  "package": {
    "name": "apache",
    "version": "1.20.0"
  },
  "name": "apache-4",
  "description": "",
  "namespace": "",
  "inputs": []
}

Test with Basic license:
image

Test with Enterprise license:
image

Checklist

@juliaElastic juliaElastic added the release_note:skip Skip the PR/issue when compiling release notes label Jul 3, 2024
@juliaElastic juliaElastic self-assigned this Jul 3, 2024
@juliaElastic juliaElastic requested a review from a team as a code owner July 3, 2024 12:01
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jul 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@criamico
Copy link
Contributor

criamico commented Jul 3, 2024

I'm not sure if the 8.15 branch was already frozen, but maybe is better to add the label anyway

@juliaElastic juliaElastic enabled auto-merge (squash) July 3, 2024 12:49
@juliaElastic juliaElastic merged commit 82d32a7 into elastic:main Jul 3, 2024
29 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @juliaElastic

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.16 The branch "8.16" does not exist

Manual backport

To create the backport manually run:

node scripts/backport --pr 187467

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants