Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] Add sanity UI tests for ESS deployments #187328

Merged
merged 20 commits into from
Jul 9, 2024
Merged

[Cloud Security] Add sanity UI tests for ESS deployments #187328

merged 20 commits into from
Jul 9, 2024

Conversation

gurevichdmitry
Copy link
Contributor

@gurevichdmitry gurevichdmitry commented Jul 2, 2024 •
edited
Loading

Summary

This PR adds sanity UI tests for all main components related to CSPM and KSPM integrations (i.e., Dashboards, Benchmarks, and Findings pages).

The following is covered:

  • Dashboard - Overall functionality and appearance check
    • Accounts - Verification of correct account count
    • Account panels - Ensuring functionality and appearance of account panels (AWS, GCP, Azure).
      • Verification of non-null values
      • Aggregation data panel
    • Navigation links - Confirmation of proper navigation links
  • Findings
    • Query + Grouping by
    • Data grid manipulations (pagination, sort)
  • Rules
    • Benchmark (Count > 0 for evaluation and compliance)

@gurevichdmitry gurevichdmitry requested a review from a team as a code owner July 2, 2024 07:33
@gurevichdmitry gurevichdmitry marked this pull request as draft July 2, 2024 07:35
@gurevichdmitry gurevichdmitry added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Jul 2, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gurevichdmitry gurevichdmitry changed the title Add sanity UI tests for ESS deployments [Cloud Security] Add sanity UI tests for ESS deployments Jul 2, 2024
@gurevichdmitry gurevichdmitry marked this pull request as ready for review July 8, 2024 07:43
@oren-zohar oren-zohar requested a review from maxcold July 9, 2024 07:49
maxcold
maxcold approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@maxcold maxcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as it's not possible atm to add smth to Kibana, eg test subjects, and check if the tests pass, we agreed to merge this pr, but create a separate ticket to add test subjects later

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #31 / machine learning - short tests Notifcations Notifications list "after all" hook for "supports custom sorting for notifications level"

Metrics [docs]

✅ unchanged

History

@gurevichdmitry
Copy link
Contributor Author

as it's not possible atm to add smth to Kibana, eg test subjects, and check if the tests pass, we agreed to merge this pr, but create a separate ticket to add test subjects later

The following tasks were opened:

@gurevichdmitry gurevichdmitry merged commit 43fca86 into elastic:main Jul 9, 2024
20 checks passed
pgayvallet pushed a commit to pgayvallet/kibana that referenced this pull request Jul 11, 2024
@gurevichdmitry @pgayvallet
[Cloud Security] Add sanity UI tests for ESS deployments (elastic#187328
10a3b56 
)

## Summary

This PR adds sanity UI tests for all main components related to CSPM and
KSPM integrations (i.e., Dashboards, Benchmarks, and Findings pages).

The following is covered:
 - Dashboard - Overall functionality and appearance check
    - Accounts - Verification of correct account count
- Account panels - Ensuring functionality and appearance of account
panels (AWS, GCP, Azure).
      - Verification of non-null values
      - Aggregation data panel
    - Navigation links - Confirmation of proper navigation links
- Findings
   - Query + Grouping by
   - Data grid manipulations (pagination, sort)
- Rules
   - Benchmark (Count > 0 for evaluation and compliance)
@gurevichdmitry gurevichdmitry mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcold maxcold maxcold approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gurevichdmitry @kibana-ci @elasticmachine @maxcold @kibanamachine