Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Unskip flaky esql columns test #187217

Merged
merged 3 commits into from
Jul 4, 2024
Merged

[Discover] Unskip flaky esql columns test #187217

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
701f99a
[Discover] Unskip tests
jughosta Jul 1, 2024
b42f96e
[Discover] Update query
jughosta Jul 1, 2024
560f353
Merge branch 'main' into 186416-fix-flaky-esql-columns-test
jughosta Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions test/functional/apps/discover/esql/_esql_columns.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
defaultIndex: 'logstash-*',
};

// FLAKY: https://github.com/elastic/kibana/issues/186416
describe.skip('discover esql columns', async function () {
describe('discover esql columns', async function () {
before(async () => {
await kibanaServer.savedObjects.cleanStandardList();
await security.testUser.setRoles(['kibana_admin', 'test_logstash_reader']);
Expand Down Expand Up @@ -95,13 +94,13 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const columns = ['@timestamp', 'Document'];
expect(await dataGrid.getHeaderFields()).to.eql(columns);

await monacoEditor.setCodeEditorValue('from logstash-* | limit 1');
await monacoEditor.setCodeEditorValue('from logstash-* | limit 500');
await testSubjects.click('querySubmitButton');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.waitUntilSearchingHasFinished();
expect(await dataGrid.getHeaderFields()).to.eql(columns);

await monacoEditor.setCodeEditorValue('from logs* | limit 1');
await monacoEditor.setCodeEditorValue('from logs* | limit 500');
await testSubjects.click('querySubmitButton');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.waitUntilSearchingHasFinished();
Expand All @@ -113,7 +112,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(await dataGrid.getHeaderFields()).to.eql(['bytes']);

// different index pattern => reset columns
await monacoEditor.setCodeEditorValue('from logstash-* | limit 1');
await monacoEditor.setCodeEditorValue('from logstash-* | limit 500');
await testSubjects.click('querySubmitButton');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.waitUntilSearchingHasFinished();
Expand Down