Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Unskip flaky esql columns test #187217

Merged
merged 3 commits into from
Jul 4, 2024
Merged

[Discover] Unskip flaky esql columns test #187217

merged 3 commits into from
Jul 4, 2024

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Jul 1, 2024 •
edited
Loading

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) labels Jul 1, 2024
@jughosta jughosta self-assigned this Jul 1, 2024
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6421

[✅] test/functional/apps/discover/esql/config.ts: 25/25 tests passed.

see run history

@jughosta
Copy link
Contributor Author

jughosta commented Jul 1, 2024

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@jughosta jughosta marked this pull request as ready for review July 1, 2024 11:41
@jughosta jughosta requested a review from a team as a code owner July 1, 2024 11:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @jughosta

kertal
kertal approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just qq; how does increasing the limit resolve the flakiness, or is this change unrelated? thx!

@jughosta
Copy link
Contributor Author

jughosta commented Jul 4, 2024

@kertal It was failing on Line 128 as after appending where bytes > 0 it could not find any results sometimes with limit 1 | where bytes > 0 condition.

@jughosta jughosta merged commit 18d2088 into elastic:main Jul 4, 2024
17 checks passed
@jughosta jughosta deleted the 186416-fix-flaky-esql-columns-test branch July 4, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

Assignees

@jughosta jughosta

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) v8.15.0
Projects
None yet
Milestone
No milestone
5 participants
@jughosta @kibanamachine @kibana-ci @elasticmachine @kertal