Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] [blocked] Display average values in chart legend for relevant time-series #84478

Open
formgeist opened this issue Nov 30, 2020 · 10 comments
Labels
apm:elastic-charts Related issues and bugs to replacing react-vis for Elastic charts blocked enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support

Comments

@formgeist
Copy link
Contributor

formgeist commented Nov 30, 2020

Summary

Extracted from #84178
Blocked by elastic/elastic-charts#580

We want to display the average value for given charts.

image

Additionally, the error occurrences chart is displaying the last bucket value rather than average value.

image

We have this functionality in our current charts implementation, so it's rather confusing not to show it in the new experience and even display values that might be very easily misunderstood, like the error occurrences chart example.

@formgeist formgeist added blocked Team:APM All issues that need APM UI Team support enhancement New value added to drive a business result labels Nov 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@formgeist formgeist changed the title [APM] Display average values in chart legend for relevant time-series [APM] [Blocked] Display average values in chart legend for relevant time-series Nov 30, 2020
@formgeist formgeist changed the title [APM] [Blocked] Display average values in chart legend for relevant time-series [APM] Display average values in chart legend for relevant time-series Nov 30, 2020
@formgeist formgeist added [zube]: Inbox apm:elastic-charts Related issues and bugs to replacing react-vis for Elastic charts labels Nov 30, 2020
@sorenlouv sorenlouv changed the title [APM] Display average values in chart legend for relevant time-series [APM] [Blocked] Display average values in chart legend for relevant time-series Nov 30, 2020
@sorenlouv
Copy link
Member

@formgeist Instead of displaying the overall average in the legends, we could add a "stat" component similar to the obs overview page.

I think it could confuse users that rest of Kibana shows the last data point in the legend, when we show the average.

@sorenlouv
Copy link
Member

If we go ahead and remove the value from the legend can we also tidy the spacing between the legends up? Any reason they are spaced out, instead of being located close together (like before migrating to Elastic charts)?

@markov00
Copy link
Member

@sqren they are spaced out because of the default min-width used in the grid layout. We have a meta issue to track the legend redesign (elastic/elastic-charts#580 point 4.) but I can't assure a specific deadline for that

@botelastic
Copy link

botelastic bot commented Nov 1, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the stale Used to mark issues that were closed for being stale label Nov 1, 2021
@sorenlouv
Copy link
Member

Just noticed this is marked as stale. It popped up again in #121405.

@botelastic botelastic bot removed the stale Used to mark issues that were closed for being stale label Dec 20, 2021
@formgeist
Copy link
Contributor Author

@sqren The extra legend component is now available, so I suppose this means we can add the avg. value there elastic/elastic-charts#561

@formgeist formgeist removed the blocked label Dec 20, 2022
@formgeist formgeist changed the title [APM] [Blocked] Display average values in chart legend for relevant time-series [APM] Display average values in chart legend for relevant time-series Dec 20, 2022
@markov00
Copy link
Member

What you can do now is more adding the ability to build your own fully custom legend.
I think you can use that if your chart is relatively straightforward (you know your series and there is no major dynamic change in series names).
We haven't exposed yet a set of legend components (like we have done for the tooltip) but we will do that soon

@formgeist
Copy link
Contributor Author

We haven't exposed yet a set of legend components (like we have done for the tooltip) but we will do that soon

Sounds like we're better off waiting for those. Do you have an issue open for this that we can track?

@formgeist formgeist changed the title [APM] Display average values in chart legend for relevant time-series [APM] [blocked] Display average values in chart legend for relevant time-series Dec 20, 2022
@markov00
Copy link
Member

We are currently working on adding this capabilities here elastic/elastic-charts#2096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:elastic-charts Related issues and bugs to replacing react-vis for Elastic charts blocked enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support
Projects
None yet
Development

No branches or pull requests

4 participants