-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Alert creation popover improvements #77589
Comments
Pinging @elastic/uptime (Team:uptime) |
It looks to me like the first screenshot could be missing A few other things worth considering:
|
I'm inclined to agree, I like it better with no title. It avoids redundancy.
I personally prefer to have icons for each of the items displayed, as I tend to zero in on the icon and look at the text if I need further information.
I am open to either of these alternatives as in practice the meaning is equivalent, but it's better to keep them synchronized. In my opinion, "Manage alerts" is more general and less prone to causing confusion, and I think this copy did originally come from design. I will add a PR and we can tweak as needed. EDITPR is here: #77633 |
I tested out your PR, and I think the transition from parent to child view in the nested panel works fine. I'm just so used to having the title there for those cases where we have nested items.
I didn't add icons for Transaction nor Error (unless you think they should have the
We (APM) just need to change to Manage alerts - we use the same in the Observability overview page, so it's just a legacy link from our Watcher integration. |
That's true - we are going to be adding alerts for synthetics in the future. Should we remove icons altogether? I believe at least the ones on the top menu were included based on design spec. |
@formgeist I've added you as a reviewer to #77633, LMK if you want me to remove icons as part of this patch or if we should table it for a later discussion. |
@justinkambic Sounds good to me, let's tackle the icons in another issue. |
Kibana version: master
Summary
There's a few enhancements we can add to make the popover consistent with the other Observability apps.
Example from APM
APM will change the active alerts link to be consistent
The text was updated successfully, but these errors were encountered: