[Uptime] Alert creation popover improvements

[formgeist]

Kibana version: master

Summary

There's a few enhancements we can add to make the popover consistent with the other Observability apps.

• The title of the popover for alerts displays a generic "main panel" title. It should say "Alerts" like the button link that invoked the popover.
• The padding inside the popover looks off, compared to the default popover.

Example from APM

APM will change the active alerts link to be consistent

[elasticmachine]

Pinging @elastic/uptime (Team:uptime)

[hbharding]

It looks to me like the first screenshot could be missing panelPaddingSize="none" on the EuiPopover.

A few other things worth considering:

• I'm wondering if the "Alerts" title is necessary in the 1st level of the context menu since it's the same text that the user clicks to activate the context menu. Feels a little redundant and adds an extra item the user needs to process. Logs and Metrics don't use a title in the 1st level of the context menu.
• Our usage of icons is inconsistent. For example, in APM the items which lead to a nested panel don't use icons, whereas Uptime uses the "alert" icon.
• Our language is inconsistent. For example "View active alerts" vs "Manage alerts". Also, some items begin with an action verb like "view" or "create", whereas others items do not.

[justinkambic]

I'm wondering if the "Alerts" title is necessary in the 1st level of the context menu since it's the same text that the user clicks to activate the context menu. Feels a little redundant and adds an extra item the user needs to process. Logs and Metrics don't use a title in the 1st level of the context menu.

I'm inclined to agree, I like it better with no title. It avoids redundancy.

Our usage of icons is inconsistent. For example, in APM the items which lead to a nested panel don't use icons, whereas Uptime uses the "alert" icon.

I personally prefer to have icons for each of the items displayed, as I tend to zero in on the icon and look at the text if I need further information.

Our language is inconsistent. For example "View active alerts" vs "Manage alerts". Also, some items begin with an action verb like "view" or "create", whereas others items do not.

I am open to either of these alternatives as in practice the meaning is equivalent, but it's better to keep them synchronized. In my opinion, "Manage alerts" is more general and less prone to causing confusion, and I think this copy did originally come from design.

I will add a PR and we can tweak as needed.

EDIT

PR is here: #77633

[formgeist]

I'm inclined to agree, I like it better with no title. It avoids redundancy.

I tested out your PR, and I think the transition from parent to child view in the nested panel works fine. I'm just so used to having the title there for those cases where we have nested items.

Our usage of icons is inconsistent. For example, in APM the items which lead to a nested panel don't use icons, whereas Uptime uses the "alert" icon.

I personally prefer to have icons for each of the items displayed, as I tend to zero in on the icon and look at the text if I need further information.

I didn't add icons for Transaction nor Error (unless you think they should have the bell icon?) because they quickly become hard to manage when we add more alert types. Same for the nested options where you have "create", having a repeated add icon doesn't help me as a user. We could also do away with the manage icon and keep it clean.

Our language is inconsistent. For example "View active alerts" vs "Manage alerts". Also, some items begin with an action verb like "view" or "create", whereas others items do not.

I am open to either of these alternatives as in practice the meaning is equivalent, but it's better to keep them synchronized. In my opinion, "Manage alerts" is more general and less prone to causing confusion, and I think this copy did originally come from design.

We (APM) just need to change to Manage alerts - we use the same in the Observability overview page, so it's just a legacy link from our Watcher integration.

[justinkambic]

I didn't add icons for Transaction nor Error (unless you think they should have the bell icon?) because they quickly become hard to manage when we add more alert types. Same for the nested options where you have "create", having a repeated add icon doesn't help me as a user. We could also do away with the manage icon and keep it clean.

That's true - we are going to be adding alerts for synthetics in the future. Should we remove icons altogether? I believe at least the ones on the top menu were included based on design spec.

[justinkambic]

@formgeist I've added you as a reviewer to #77633, LMK if you want me to remove icons as part of this patch or if we should table it for a later discussion.

[formgeist]

@justinkambic Sounds good to me, let's tackle the icons in another issue.