Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in Index Management "mappings" #59085

Closed
kindsun opened this issue Mar 2, 2020 · 3 comments · Fixed by #66012
Closed

Typo in Index Management "mappings" #59085

kindsun opened this issue Mar 2, 2020 · 3 comments · Fixed by #66012
Assignees
@yuliacech
Labels
bug Fixes for quality problems that affect the customer experience Feature:Index Management Index and index templates UI good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@kindsun
Copy link
Contributor

kindsun commented Mar 2, 2020

Kibana version:

7.5.x
8.0

Describe the bug:

Probably a one character fix! Currently Index Management shows mappings as mapping. Confirmed on 7.5.x and master.

image
@kindsun kindsun added bug Fixes for quality problems that affect the customer experience Feature:Index Management Index and index templates UI v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.5.0 labels Mar 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@cjcenizal cjcenizal added good first issue low hanging fruit and removed v7.5.0 v8.0.0 labels May 5, 2020
@yuliacech yuliacech self-assigned this May 8, 2020
@yuliacech
Copy link
Contributor

Hi @aaronjcaldwell, I'm currently looking into this issue and found how to change mapping to mappings in the json preview, so I'll be creating a short PR soon.
Do you think we need to update tab title to "Mappings" as well?

@yuliacech yuliacech mentioned this issue May 11, 2020
Merged
@kindsun
Copy link
Contributor Author

kindsun commented May 12, 2020

@yuliacech Yes, I would update the tab title as well. That would be consistent with how we've used the term elsewhere (for example here) and I think would be less confusing to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuliacech yuliacech

Labels
bug Fixes for quality problems that affect the customer experience Feature:Index Management Index and index templates UI good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes index mapping api response to plural form yuliacech/kibana
4 participants
@cjcenizal @kindsun @yuliacech @elasticmachine