Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Arch] migrate legacy CSS to new platform #55493

Closed
9 of 10 tasks
lukeelmers opened this issue Jan 22, 2020 · 4 comments
Closed
9 of 10 tasks

[App Arch] migrate legacy CSS to new platform #55493

lukeelmers opened this issue Jan 22, 2020 · 4 comments

Comments

@lukeelmers
Copy link
Member

lukeelmers commented Jan 22, 2020

Blocked by #53532

There are a number of places where we have left behind some CSS in the legacy world due to lack of support for it in the new platform, and as a workaround are importing that CSS into the new platform. This should now be unblocked, so we need to move over any legacy CSS as a cleanup step.

@streamich has started this work in #52414, so we can either update/merge that PR, or copy the work he has done so far into a new PR and close the original.

Here's a list of app arch legacy items I've found so far which contain some scss (be sure to look around for anything I may have missed):

Related to #58369

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@streamich
Copy link
Contributor

I have a PR open that addresses this for some plugins: #52414

@joshdover
Copy link
Contributor

Should be unblocked on this now that we have CSS and SCSS imports in Webpack supported for New Platform plugins.

@lukeelmers
Copy link
Member Author

I think this can be closed. ui/_index.scss is currently only referencing the management plugin, which folks can import directly as they migrate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants