Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NP Migration: Dashboard URLs #49060

Closed
flash1293 opened this issue Oct 23, 2019 · 3 comments · Fixed by #63443
Closed

NP Migration: Dashboard URLs #49060

flash1293 opened this issue Oct 23, 2019 · 3 comments · Fixed by #63443
Labels
discuss Feature:Dashboard Dashboard related features Feature:NP Migration Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

flash1293 commented Oct 23, 2019

When moving to NP we plan to split up the current "kibana" app into multiple apps for the various parts (discover, dashboard, visualize, management and so on).

To do this we have to migrate the URLs. Currently dashboard is using the following routes:

  • /app/kibana#/dashboards as listing page
  • /app/kibana#/dashboard as new dashboard page
  • /app/kibana#/dashboard/:id as saved dashboard page

URLs are mapped to their respective apps by the URL prefix which means it should not use both dashboards and dashboard as a first path segment.

We can keep both prefixes for now and just re-initialize the app when switching between listing and actual dashboard, but on the new platform we should clean this app as we have to forward URLs anyway. Suggestion:

  • app/dashboards as listing page
  • app/dashboards/create as new dashboard page
  • app/dashboards/view/:id as saved dashboard page

With this scheme we can safely forward existing URLs to their new counterparts. It is also close to the URLs of visualize ( /visualize for listing, /visualize/create for new visualizations, visualize/edit/:id for existing visualizations). Having /view/:id also containing the edit mode is not super nice (having a separate /edit/:id path would be better) but as this is currently part of the app state it's difficult to migrate, so I don't think the complexity is justified.

@flash1293 flash1293 added discuss Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:NP Migration labels Oct 23, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor Author

ping @timroes @kertal

@timroes
Copy link
Contributor

timroes commented Dec 16, 2019

I like the suggestion of the new URL schema here. I think we def want to have an "action" before the :id in the URL (as you suggested here with create/view), since we might want to add more "short URLs" for linking (see this comment).

I also think we might want to have an explicit dashboards/list URL and just make dashboards forward to this, that'll give us the opportunity later to change that default behavior for users coming in via the implicit (dashboards) URL, to e.g. load a default dashboard instead of the list.

also cc @majagrubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Feature:Dashboard Dashboard related features Feature:NP Migration Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants