[8.15] [Security Solution] [Attack discovery] Updates Gemini connector to ignore unknown properties in responses (#192915) #193221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nore unknown properties in responses (elastic#192915) ## [Security Solution] [Attack discovery] Updates Gemini connector to ignore unknown properties in responses ### Summary This PR updates the Gemini connector's `RunApiResponseSchema` to ignore unknown properties in responses. It fixes an issue where the recent addition of a `modelVersion` in Gemini responses causes Attack discovery to fail with the following error: ``` Attack discovery generation failed ActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing) ``` shown in the screenshot below:  ### Desk testing To reproduce: 1) Navigate to Security > Attack discovery 2) Select a Gemini connector 3) Click Generate **Expected result** - Attack discoveries are generated **Actual result** - The following error is displayed: ``` Attack discovery generation failed ActionsClientLlm: action result status is error: an error occurred while running the action - Response validation failed (Error: [modelVersion]: definition for this key is missing) ```  (cherry picked from commit 699db81)
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.15:Questions ?
Please refer to the Backport tool documentation