Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Obs Synthetics > Monitor Test Run][SCREEN READER]: Table rows need TH[scope="row"] for SR usability: 0017 #186957

Merged
merged 2 commits into from
Jul 1, 2024
Merged

fix: [Obs Synthetics > Monitor Test Run][SCREEN READER]: Table rows need TH[scope="row"] for SR usability: 0017 #186957

merged 2 commits into from
Jul 1, 2024
+1 −0

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jun 26, 2024 •
edited
Loading

Closes: https://github.com/elastic/observability-dev/issues/3570

Summary

rowHeader attribute was added for the following table

Screenshot 2024-06-26 at 11 37 56

@alexwizp
Copy link
Contributor Author

/ci

@alexwizp alexwizp added Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.15.0 labels Jun 26, 2024
@alexwizp alexwizp marked this pull request as ready for review June 26, 2024 10:31
@alexwizp alexwizp requested a review from a team as a code owner June 26, 2024 10:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Jun 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.0MB 1.0MB +23.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit 3dddc52 into elastic:main Jul 1, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexwizp @elasticmachine @kibana-ci @justinkambic