Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard avoid reliance on broadcast emits #14789

Closed
stacey-gammon opened this issue Nov 6, 2017 · 1 comment
Closed

Dashboard avoid reliance on broadcast emits #14789

stacey-gammon opened this issue Nov 6, 2017 · 1 comment
Labels
chore Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@stacey-gammon
Copy link
Contributor

Currently dashboard relies on a signal 'ready:vis' being emitted from root scope from the visualizations. That emit causes issues with visualizations embedded in tooltips, but taking it off rootscope broke dashboard (#14674).

Dashboard and embeddables should be able to be written in any framework so we need to break this reliance and put it back on the embeddable API, to give a way for the embeddables to communicate to dashboard that they have finished rendering.

Why do we even need this knowledge? Well currently, it's used to re-fetch a request in courier to trigger a fetch on saved searches (hence the bug). Other than that, I believe it's useful for plugins to know when the dashboard is completely finished loading.

@stacey-gammon stacey-gammon added Feature:Dashboard Dashboard related features :Sharing chore labels Nov 6, 2017
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed :Sharing labels Sep 14, 2018
@timroes timroes added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 7, 2020
@timroes
Copy link
Contributor

timroes commented Oct 19, 2021

I am going as far and assume with the removal of Angular (#115464) this is no longer a problem and closing it.

@timroes timroes closed this as completed Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

2 participants