Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Kibana table column width using percents #134800

Closed
Tracked by #166238
alytkowski opened this issue Jun 21, 2022 · 10 comments
Closed
Tracked by #166238

Change Kibana table column width using percents #134800

alytkowski opened this issue Jun 21, 2022 · 10 comments
Labels
enhancement New value added to drive a business result EUI Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. upstream

Comments

@alytkowski
Copy link

Describe the feature:
Change the code in a way, that resizing(customizing) the Kibana table columns(In Discover) is not performed statically, but by using percentage.
Describe a specific use case for the feature:
This would ensure that the columns autofit to the display resolution, but also maintain the custom column width.
Currently, to ensure that the column width autofit, you can't customize it, and as a result all of the columns width are the same - sometimes you'd want to have a field with larger column width and some other smaller - this has been working fine in the 8.1.1 version.

@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 21, 2022
@jughosta jughosta added the Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) label Jun 21, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 21, 2022
@jughosta jughosta added enhancement New value added to drive a business result needs-team Issues missing a team label labels Jun 21, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 21, 2022
@jughosta
Copy link
Contributor

@alytkowski Thanks for your suggestion!
Linking to the original discussion https://discuss.elastic.co/t/kibana-table-resizing-of-columns/307633

@jughosta
Copy link
Contributor

@constancecchen Would it possible to add support for it in EuiDataGrid?

@cee-chen
Copy link
Member

At first glance, my best guess is that it would be a moderate technical lift to implement, so not something we could quickly add. Feel free to open an issue in the EUI repo for it however!

I'll also note that I'm not the definitive owner of EuiDataGrid, so don't take my word as 100% truth - @chandlerprall is + owner of the datagrid roadmap/priorities, so def feel free to ping him as well for feature & enhancement requests!

@chandlerprall
Copy link
Contributor

This request is partially captured in elastic/eui#4019, specifically elastic/eui#4019 (comment). Unfortunately the difficulty isn't as much technical, but finding functional, discoverable, and accessible user interactions.

@cee-chen
Copy link
Member

@chandlerprall I'm not totally sure that's the same feature request - it sounds like the request here is to be able to set columns.someColumn.initialWidth = "20%" for example, instead of initialWidth being limited to a static pixel width of, e.g., 300.

@chandlerprall
Copy link
Contributor

Re-reading the thread & comment I linked to, it does not cover this case. We've had the conversation before but apparently not in github.

it sounds like the request here is to be able to set columns.someColumn.initialWidth = "20%" for example

Not only the initial width but the user's resize actions too,

resizing(customizing) the Kibana table columns

We have this set up in EuiResizableContainer, where percentages are tracked and updating one affects its neighbor(s).

At a technical level, adding this to the data grid would mean expanding the existing pixel-based widths to accept percentages, and similarly the callbacks would need to respond with a matching unit.

I wonder if we could avoid user experience changes by just responding based on the column width type. Mixed types may be awkward when the dimensions change, but solvable if the app always uses percentages.

@cee-chen
Copy link
Member

Ahh I definitely missed the user resize context, apologies. ++ to everything you're saying!

@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

@ninoslavmiskovic ninoslavmiskovic removed the Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) label Oct 13, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 13, 2022
@afharo afharo added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Oct 24, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 24, 2022
@davismcphee davismcphee added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated labels Sep 8, 2023
@kertal kertal added the Icebox label Nov 6, 2023
@kertal
Copy link
Member

kertal commented Nov 6, 2023

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@kertal kertal closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result EUI Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. upstream
Projects
None yet
Development

No branches or pull requests

9 participants