Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Make values render in expanded popover formatted (and fix JSON) #118162

Closed
Tracked by #85965
timroes opened this issue Nov 10, 2021 · 3 comments · Fixed by #123194
Closed
Tracked by #85965

[Discover] Make values render in expanded popover formatted (and fix JSON) #118162

timroes opened this issue Nov 10, 2021 · 3 comments · Fixed by #123194
Labels
Feature:Discover Discover Application loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews)

Comments

@timroes
Copy link
Contributor

timroes commented Nov 10, 2021 •
edited
Loading

We want to have a look over how data grid does render values in discover when you open the popover of a cell. Currently we simply show the JSON there, but instead we want to make sure we're properly using field formatter and only show JSON in some rare cases were it might make sense (to be defined).
@timroes timroes mentioned this issue Nov 10, 2021
Closed
41 tasks
@timroes timroes changed the title Make values render in expanded popover formatted (and fix JSON) [Discover] Make values render in expanded popover formatted (and fix JSON) Nov 10, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 10, 2021
@timroes timroes added Feature:Discover Discover Application Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) labels Nov 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 10, 2021
@ryankeairns
Copy link
Contributor

@kertal any sense of the size of effort on this issue?

cc:/ @shaunmcgough

@kertal kertal added the loe:small Small Level of Effort label Jan 12, 2022
@kertal
Copy link
Member

kertal commented Jan 12, 2022 •
edited
Loading

should be doable in a few hours (if there are no special requests)

@kertal kertal mentioned this issue Jan 20, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Discover Discover Application loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Fix document explorer cell popover rendering kertal/kibana
4 participants
@ryankeairns @kertal @timroes @elasticmachine