[Lens] Auto height setting for table

[flash1293]

Aggregation based table has a setting to scale the row height of the table by the content. We should allow the user to specify this in Lens as well.

[elasticmachine]

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

[flash1293]

The switch for the setting should be placed in a tooltip popover like the legend settings for heatmap:

[VladLasitsa]

@flash1293 , we have the following task elastic/eui#5080 which provide a control inside grid which allow to switch between auto-height and usual state. I am not sure that we need add truncate text to legend. Also I have question about should we store this auto-height state in saved object?

[flash1293]

@VladLasitsa I think it makes sense to put it into the Lens toolbar for now because:

• it’s aligned with visualize data table
• It’s how we deal with other settings like that
• We are not showing the data grid toolbar in Lens and I don’t think we want to start doing it because the Lens toolbar with the chart Switcher is right there already

We absolutely should store this in the saved object, this is the most important part. Even if we decide to show the data grid toolbar at some point, we still want to store this setting in the saved object.

[MichaelMarcialis]

@VladLasitsa I think it makes sense to put it into the Lens toolbar for now because:

• it’s aligned with visualize data table
• It’s how we deal with other settings like that
• We are not showing the data grid toolbar in Lens and I don’t think we want to start doing it because the Lens toolbar with the chart Switcher is right there already

Regarding this topic, I think we need to ask ourselves whether or not it would valuable for consumers/viewers of the visualization (i.e. not the person creating the visualization in Lens) to have access to this row height control. For example, is there a use case for folks viewing a Lens visualization in a dashboard to change this row height option and have that change stored client-side?

If there is such a use case, then perhaps we should talk about introducing the data grid toolbar.

If there is no such use case, then I agree with @flash1293 on placing this new option in the Lens app toolbar. As table visualizations don't currently have any toolbar buttons beyond visualization type, we'll need to add a new button called "Appearance" and using the brush icon (similar to what we're planning for gauge visualizations).

[flash1293]

This is a good point, but IMHO it’s a rare case to change this setting on a dashboard (at least too rare to introduce the toolbar for it which would take away quite a bit of vertical space, especially if there are multiple tables on a dense dashboard). Also, there’s another issue we would like to work on soon (allowing to paginate the table) which could go into the same popover menu - it seems like the most consistent approach to me.

We could of course introduce a “show toolbar” switch, but that seems like overcomplicating the issue - I think it makes sense to go with the setting in Lens editor for now and see whether users request more control.

[flash1293]

Cc @ghudgins what do you think about this?

[ghudgins]

I think we have a number of data grid things we might want to expose outside of the editor but for the sake of this issue we don't need to solve for those edit-from-view cases here. I also agree, for this case, it's definitely more rare than changing sorting or resizing a column.