From c53830d90b3c89fd36987f8b2ba55e2dc2e12704 Mon Sep 17 00:00:00 2001 From: James Gowdy Date: Fri, 13 Mar 2020 16:32:37 +0000 Subject: [PATCH] fixing types and ml icon order --- x-pack/plugins/ml/public/plugin.ts | 2 +- .../lib/ml_telemetry/ml_telemetry.test.ts | 34 +++++++++---------- x-pack/plugins/ml/tsconfig.json | 2 +- 3 files changed, 19 insertions(+), 19 deletions(-) diff --git a/x-pack/plugins/ml/public/plugin.ts b/x-pack/plugins/ml/public/plugin.ts index e5a512f6ab74176..ef85a36494df521 100644 --- a/x-pack/plugins/ml/public/plugin.ts +++ b/x-pack/plugins/ml/public/plugin.ts @@ -31,8 +31,8 @@ export class MlPlugin implements Plugin { title: i18n.translate('xpack.ml.plugin.title', { defaultMessage: 'Machine Learning', }), + order: 30, euiIconType: PLUGIN_ICON, - order: 8001, appRoute: '/app/ml', mount: async (params: AppMountParameters) => { const [coreStart, pluginsStart] = await core.getStartServices(); diff --git a/x-pack/plugins/ml/server/lib/ml_telemetry/ml_telemetry.test.ts b/x-pack/plugins/ml/server/lib/ml_telemetry/ml_telemetry.test.ts index 188b1182751b93c..cda160877f7aefc 100644 --- a/x-pack/plugins/ml/server/lib/ml_telemetry/ml_telemetry.test.ts +++ b/x-pack/plugins/ml/server/lib/ml_telemetry/ml_telemetry.test.ts @@ -4,13 +4,13 @@ * you may not use this file except in compliance with the Elastic License. */ -import { - // createMlTelemetry, - // incrementFileDataVisualizerIndexCreationCount, - // ML_TELEMETRY_DOC_ID, - MlTelemetry, - // storeMlTelemetry, -} from './ml_telemetry'; +// import { +// createMlTelemetry, +// incrementFileDataVisualizerIndexCreationCount, +// ML_TELEMETRY_DOC_ID, +// MlTelemetry, +// storeMlTelemetry, +// } from './ml_telemetry'; describe('ml_telemetry', () => { describe('createMlTelemetry', () => { @@ -25,17 +25,17 @@ describe('ml_telemetry', () => { }); describe('storeMlTelemetry', () => { - let mlTelemetry: MlTelemetry; - let internalRepository: any; + // let mlTelemetry: MlTelemetry; + // let internalRepository: any; - beforeEach(() => { - internalRepository = { create: jest.fn(), get: jest.fn() }; - mlTelemetry = { - file_data_visualizer: { - index_creation_count: 1, - }, - }; - }); + // beforeEach(() => { + // internalRepository = { create: jest.fn(), get: jest.fn() }; + // mlTelemetry = { + // file_data_visualizer: { + // index_creation_count: 1, + // }, + // }; + // }); it('should call internalRepository create with the given MlTelemetry object', () => { // storeMlTelemetry(internalRepository, mlTelemetry); diff --git a/x-pack/plugins/ml/tsconfig.json b/x-pack/plugins/ml/tsconfig.json index 618c6c3e97b5769..4082f16a5d91ce6 100644 --- a/x-pack/plugins/ml/tsconfig.json +++ b/x-pack/plugins/ml/tsconfig.json @@ -1,3 +1,3 @@ { - "extends": "../../../tsconfig.json" + "extends": "../../tsconfig.json" }