From b77625903650c9e919e23d5b336baee7007e0249 Mon Sep 17 00:00:00 2001
From: Jean-Louis Leysens <jloleysens@gmail.com>
Date: Fri, 9 Aug 2024 12:08:55 +0200
Subject: [PATCH] do not assign required if array is empty

---
 .../post_process_mutations/mutations/object.test.ts        | 7 ++-----
 .../post_process_mutations/mutations/object.ts             | 2 +-
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/packages/kbn-router-to-openapispec/src/oas_converter/kbn_config_schema/post_process_mutations/mutations/object.test.ts b/packages/kbn-router-to-openapispec/src/oas_converter/kbn_config_schema/post_process_mutations/mutations/object.test.ts
index fd7b127ef87260..ae257aaec1edff 100644
--- a/packages/kbn-router-to-openapispec/src/oas_converter/kbn_config_schema/post_process_mutations/mutations/object.test.ts
+++ b/packages/kbn-router-to-openapispec/src/oas_converter/kbn_config_schema/post_process_mutations/mutations/object.test.ts
@@ -11,13 +11,10 @@ import { joi2JsonInternal } from '../../parse';
 import { processObject } from './object';
 
 test.each([
-  [
-    schema.object({}),
-    { type: 'object', properties: {}, additionalProperties: false, required: [] },
-  ],
+  [schema.object({}), { type: 'object', properties: {}, additionalProperties: false }],
   [
     schema.object({ never: schema.never() }),
-    { type: 'object', properties: {}, additionalProperties: false, required: [] },
+    { type: 'object', properties: {}, additionalProperties: false },
   ],
   [
     schema.object(
diff --git a/packages/kbn-router-to-openapispec/src/oas_converter/kbn_config_schema/post_process_mutations/mutations/object.ts b/packages/kbn-router-to-openapispec/src/oas_converter/kbn_config_schema/post_process_mutations/mutations/object.ts
index ec5888f986bd60..0b21134061c78e 100644
--- a/packages/kbn-router-to-openapispec/src/oas_converter/kbn_config_schema/post_process_mutations/mutations/object.ts
+++ b/packages/kbn-router-to-openapispec/src/oas_converter/kbn_config_schema/post_process_mutations/mutations/object.ts
@@ -38,7 +38,7 @@ const populateRequiredFields = (schema: OpenAPIV3.SchemaObject): void => {
     }
   }
 
-  schema.required = required;
+  if (required.length > 0) schema.required = required;
 };
 
 const removeNeverType = (schema: OpenAPIV3.SchemaObject): void => {