From 9a855bd95b36dfe391c4aed8fa684c2a23579e03 Mon Sep 17 00:00:00 2001 From: Constance Chen Date: Thu, 24 Sep 2020 12:29:58 -0700 Subject: [PATCH] :fire: Remove temporary externalUrl workaround - set in https://github.com/elastic/kibana/pull/78368/commits/9d993d8e5d71c66b3a8a3584d89eceeb46fee8da - WorkplaceSearchHeaderActions should now still have the correct URL - and also now be able to access all Kea logic set up by the main app :) --- x-pack/plugins/enterprise_search/public/plugin.ts | 5 ----- 1 file changed, 5 deletions(-) diff --git a/x-pack/plugins/enterprise_search/public/plugin.ts b/x-pack/plugins/enterprise_search/public/plugin.ts index ede3083ad5518b..c63232b0c8a7fa 100644 --- a/x-pack/plugins/enterprise_search/public/plugin.ts +++ b/x-pack/plugins/enterprise_search/public/plugin.ts @@ -23,7 +23,6 @@ import { WORKPLACE_SEARCH_PLUGIN, } from '../common/constants'; import { IInitialAppData } from '../common/types'; -import { externalUrl } from './applications/shared/enterprise_search_url'; export interface ClientConfigType { host?: string; @@ -168,10 +167,6 @@ export class EnterpriseSearchPlugin implements Plugin { try { this.data = await http.get('/api/enterprise_search/config_data'); this.hasInitialized = true; - - // TODO: This is a temporary workaround to keep the WorkplaceSearchHeaderActions working. - // We'll solve this shortly by ensuring the main app store loads before the header actions. - externalUrl.enterpriseSearchUrl = this.data.publicUrl || this.config.host; } catch { this.data.errorConnecting = true; }