From 7a8ce915656399399d09cba609793836fce6b16d Mon Sep 17 00:00:00 2001 From: Rashmi Kulkarni Date: Wed, 3 Feb 2021 12:45:13 -0800 Subject: [PATCH] unskip maps functional tests --- x-pack/test/functional/apps/maps/layer_errors.js | 12 ++++++------ x-pack/test/functional/apps/maps/sample_data.js | 12 +++--------- 2 files changed, 9 insertions(+), 15 deletions(-) diff --git a/x-pack/test/functional/apps/maps/layer_errors.js b/x-pack/test/functional/apps/maps/layer_errors.js index 83b533a5599438..588fa202cf0058 100644 --- a/x-pack/test/functional/apps/maps/layer_errors.js +++ b/x-pack/test/functional/apps/maps/layer_errors.js @@ -9,8 +9,7 @@ import expect from '@kbn/expect'; export default function ({ getPageObjects }) { const PageObjects = getPageObjects(['maps', 'header']); - // Failing: See https://github.com/elastic/kibana/issues/69617 - describe.skip('layer errors', () => { + describe('layer errors', () => { before(async () => { await PageObjects.maps.loadSavedMap('layer with errors'); }); @@ -65,14 +64,15 @@ export default function ({ getPageObjects }) { }); }); - // FLAKY: https://github.com/elastic/kibana/issues/36011 - describe.skip('EMSFileSource with missing EMS id', () => { + describe('EMSFileSource with missing EMS id', () => { const MISSING_EMS_ID = 'idThatDoesNotExitForEMSFileSource'; const LAYER_NAME = 'EMS_vector_shapes'; it('should diplay error message in layer panel', async () => { const errorMsg = await PageObjects.maps.getLayerErrorText(LAYER_NAME); - expect(errorMsg).to.equal(`Unable to find EMS vector shapes for id: ${MISSING_EMS_ID}`); + expect(errorMsg).to.equal( + `Unable to find EMS vector shapes for id: ${MISSING_EMS_ID}. Kibana is unable to access Elastic Maps Service. Contact your systemadministrator.` + ); }); it('should allow deletion of layer', async () => { @@ -89,7 +89,7 @@ export default function ({ getPageObjects }) { it('should diplay error message in layer panel', async () => { const errorMsg = await PageObjects.maps.getLayerErrorText(LAYER_NAME); expect(errorMsg).to.equal( - `Unable to find EMS tile configuration for id: ${MISSING_EMS_ID}` + `Unable to find EMS tile configuration for id: ${MISSING_EMS_ID}. Kibana is unable to access Elastic Maps Service. Contact your systemadministrator.` ); }); diff --git a/x-pack/test/functional/apps/maps/sample_data.js b/x-pack/test/functional/apps/maps/sample_data.js index 348151778c27c7..6a5c0368e50476 100644 --- a/x-pack/test/functional/apps/maps/sample_data.js +++ b/x-pack/test/functional/apps/maps/sample_data.js @@ -10,8 +10,7 @@ export default function ({ getPageObjects, getService, updateBaselines }) { const PageObjects = getPageObjects(['common', 'maps', 'header', 'home', 'timePicker']); const screenshot = getService('screenshots'); - // FLAKY: https://github.com/elastic/kibana/issues/38137 - describe.skip('maps loaded from sample data', () => { + describe('maps loaded from sample data', () => { // Sample data is shifted to be relative to current time // This means that a static timerange will return different documents // Setting the time range to a window larger than the sample data set @@ -21,13 +20,9 @@ export default function ({ getPageObjects, getService, updateBaselines }) { past.setMonth(past.getMonth() - 6); const future = new Date(); future.setMonth(future.getMonth() + 6); - await PageObjects.maps.setAbsoluteRange( - PageObjects.timePicker.formatDateToAbsoluteTimeString(past), - PageObjects.timePicker.formatDateToAbsoluteTimeString(future) - ); + await PageObjects.maps.setAbsoluteRange(past.toISOString(), future.toISOString()); } - // Skipped because EMS vectors are not accessible in CI describe('ecommerce', () => { before(async () => { await PageObjects.common.navigateToUrl('home', '/tutorial_directory/sampleData', { @@ -59,7 +54,7 @@ export default function ({ getPageObjects, getService, updateBaselines }) { 'ecommerce_map', updateBaselines ); - expect(percentDifference).to.be.lessThan(0.05); + expect(percentDifference).to.be.lessThan(0.06); }); }); @@ -94,7 +89,6 @@ export default function ({ getPageObjects, getService, updateBaselines }) { }); }); - // Skipped because EMS vectors are not accessible in CI describe('web logs', () => { before(async () => { await PageObjects.common.navigateToUrl('home', '/tutorial_directory/sampleData', {