diff --git a/x-pack/plugins/observability_solution/slo/server/services/transform_generators/apm_transaction_duration.test.ts b/x-pack/plugins/observability_solution/slo/server/services/transform_generators/apm_transaction_duration.test.ts index 4517ef38865956..b764b83ea93496 100644 --- a/x-pack/plugins/observability_solution/slo/server/services/transform_generators/apm_transaction_duration.test.ts +++ b/x-pack/plugins/observability_solution/slo/server/services/transform_generators/apm_transaction_duration.test.ts @@ -153,7 +153,7 @@ describe('APM Transaction Duration Transform Generator', () => { expect(transform.pivot?.group_by).toMatchSnapshot(); }); - it("overrides the range filter when 'preventInitialBackfill' is true", () => { + it("overrides the range filter when 'preventInitialBackfill' is true", async () => { const slo = createSLO({ indicator: createAPMTransactionDurationIndicator(), settings: { @@ -163,7 +163,7 @@ describe('APM Transaction Duration Transform Generator', () => { }, }); - const transform = generator.getTransformParams(slo, spaceId, dataViewsService); + const transform = await generator.getTransformParams(slo, spaceId, dataViewsService); // @ts-ignore const rangeFilter = transform.source.query.bool.filter.find((f) => 'range' in f); diff --git a/x-pack/plugins/observability_solution/slo/server/services/transform_generators/apm_transaction_error_rate.test.ts b/x-pack/plugins/observability_solution/slo/server/services/transform_generators/apm_transaction_error_rate.test.ts index 327a31029b076e..13c73443960afe 100644 --- a/x-pack/plugins/observability_solution/slo/server/services/transform_generators/apm_transaction_error_rate.test.ts +++ b/x-pack/plugins/observability_solution/slo/server/services/transform_generators/apm_transaction_error_rate.test.ts @@ -156,7 +156,7 @@ describe('APM Transaction Error Rate Transform Generator', () => { expect(transform.pivot?.group_by).toMatchSnapshot(); }); - it("overrides the range filter when 'preventInitialBackfill' is true", () => { + it("overrides the range filter when 'preventInitialBackfill' is true", async () => { const slo = createSLO({ indicator: createAPMTransactionErrorRateIndicator(), settings: { @@ -166,7 +166,7 @@ describe('APM Transaction Error Rate Transform Generator', () => { }, }); - const transform = generator.getTransformParams(slo, spaceId, dataViewsService); + const transform = await generator.getTransformParams(slo, spaceId, dataViewsService); // @ts-ignore const rangeFilter = transform.source.query.bool.filter.find((f) => 'range' in f); diff --git a/x-pack/plugins/observability_solution/slo/server/services/transform_generators/histogram.test.ts b/x-pack/plugins/observability_solution/slo/server/services/transform_generators/histogram.test.ts index ac77d247bb7cd8..ea342397dd82a9 100644 --- a/x-pack/plugins/observability_solution/slo/server/services/transform_generators/histogram.test.ts +++ b/x-pack/plugins/observability_solution/slo/server/services/transform_generators/histogram.test.ts @@ -31,12 +31,13 @@ describe('Histogram Transform Generator', () => { }, }), }); + expect(generator.getTransformParams(anSLO, spaceId, dataViewsService)).rejects.toThrow( /Invalid KQL: foo:/ ); }); - it('throws when the total filter is invalid', () => { + it('throws when the total filter is invalid', async () => { const anSLO = createSLO({ indicator: createHistogramIndicator({ good: { @@ -46,6 +47,7 @@ describe('Histogram Transform Generator', () => { }, }), }); + expect(generator.getTransformParams(anSLO, spaceId, dataViewsService)).rejects.toThrow( /Invalid KQL: foo:/ ); @@ -174,7 +176,7 @@ describe('Histogram Transform Generator', () => { expect(transform.pivot!.aggregations!['slo.denominator']).toMatchSnapshot(); }); - it("overrides the range filter when 'preventInitialBackfill' is true", () => { + it("overrides the range filter when 'preventInitialBackfill' is true", async () => { const slo = createSLO({ indicator: createHistogramIndicator(), settings: { @@ -184,7 +186,7 @@ describe('Histogram Transform Generator', () => { }, }); - const transform = generator.getTransformParams(slo, spaceId, dataViewsService); + const transform = await generator.getTransformParams(slo, spaceId, dataViewsService); // @ts-ignore const rangeFilter = transform.source.query.bool.filter.find((f) => 'range' in f); diff --git a/x-pack/plugins/observability_solution/slo/server/services/transform_generators/kql_custom.test.ts b/x-pack/plugins/observability_solution/slo/server/services/transform_generators/kql_custom.test.ts index d41ed8fbcb2e2f..8f15bc49f134b5 100644 --- a/x-pack/plugins/observability_solution/slo/server/services/transform_generators/kql_custom.test.ts +++ b/x-pack/plugins/observability_solution/slo/server/services/transform_generators/kql_custom.test.ts @@ -130,7 +130,7 @@ describe('KQL Custom Transform Generator', () => { expect(transform.pivot!.aggregations!['slo.denominator']).toMatchSnapshot(); }); - it("overrides the range filter when 'preventInitialBackfill' is true", () => { + it("overrides the range filter when 'preventInitialBackfill' is true", async () => { const slo = createSLO({ indicator: createKQLCustomIndicator(), settings: { @@ -140,7 +140,7 @@ describe('KQL Custom Transform Generator', () => { }, }); - const transform = generator.getTransformParams(slo, spaceId, dataViewsService); + const transform = await generator.getTransformParams(slo, spaceId, dataViewsService); // @ts-ignore const rangeFilter = transform.source.query.bool.filter.find((f) => 'range' in f); diff --git a/x-pack/plugins/observability_solution/slo/server/services/transform_generators/metric_custom.test.ts b/x-pack/plugins/observability_solution/slo/server/services/transform_generators/metric_custom.test.ts index 2ece33b94ff19a..8484c9ef0edb9b 100644 --- a/x-pack/plugins/observability_solution/slo/server/services/transform_generators/metric_custom.test.ts +++ b/x-pack/plugins/observability_solution/slo/server/services/transform_generators/metric_custom.test.ts @@ -229,7 +229,7 @@ describe('Metric Custom Transform Generator', () => { expect(transform.pivot!.aggregations!['slo.denominator']).toMatchSnapshot(); }); - it("overrides the range filter when 'preventInitialBackfill' is true", () => { + it("overrides the range filter when 'preventInitialBackfill' is true", async () => { const slo = createSLO({ indicator: createMetricCustomIndicator(), settings: { @@ -239,7 +239,7 @@ describe('Metric Custom Transform Generator', () => { }, }); - const transform = generator.getTransformParams(slo, spaceId, dataViewsService); + const transform = await generator.getTransformParams(slo, spaceId, dataViewsService); // @ts-ignore const rangeFilter = transform.source.query.bool.filter.find((f) => 'range' in f); diff --git a/x-pack/plugins/observability_solution/slo/server/services/transform_generators/synthetics_availability.test.ts b/x-pack/plugins/observability_solution/slo/server/services/transform_generators/synthetics_availability.test.ts index 362310a2a3fdf6..b292b8d12f342f 100644 --- a/x-pack/plugins/observability_solution/slo/server/services/transform_generators/synthetics_availability.test.ts +++ b/x-pack/plugins/observability_solution/slo/server/services/transform_generators/synthetics_availability.test.ts @@ -407,7 +407,7 @@ describe('Synthetics Availability Transform Generator', () => { }); }); - it("overrides the range filter when 'preventInitialBackfill' is true", () => { + it("overrides the range filter when 'preventInitialBackfill' is true", async () => { const slo = createSLO({ indicator: createSyntheticsAvailabilityIndicator(), settings: { @@ -417,7 +417,7 @@ describe('Synthetics Availability Transform Generator', () => { }, }); - const transform = generator.getTransformParams(slo, 'default', dataViewsService); + const transform = await generator.getTransformParams(slo, 'default', dataViewsService); // @ts-ignore const rangeFilter = transform.source.query.bool.filter.find((f) => 'range' in f); diff --git a/x-pack/plugins/observability_solution/slo/server/services/transform_generators/timeslice_metric.test.ts b/x-pack/plugins/observability_solution/slo/server/services/transform_generators/timeslice_metric.test.ts index 8351d0e36e05c8..9986f9690c84a7 100644 --- a/x-pack/plugins/observability_solution/slo/server/services/transform_generators/timeslice_metric.test.ts +++ b/x-pack/plugins/observability_solution/slo/server/services/transform_generators/timeslice_metric.test.ts @@ -175,7 +175,7 @@ describe('Timeslice Metric Transform Generator', () => { }); }); - it("overrides the range filter when 'preventInitialBackfill' is true", () => { + it("overrides the range filter when 'preventInitialBackfill' is true", async () => { const slo = createSLOWithTimeslicesBudgetingMethod({ indicator: everythingIndicator, settings: { @@ -185,7 +185,7 @@ describe('Timeslice Metric Transform Generator', () => { }, }); - const transform = generator.getTransformParams(slo, spaceId, dataViewsService); + const transform = await generator.getTransformParams(slo, spaceId, dataViewsService); // @ts-ignore const rangeFilter = transform.source.query.bool.filter.find((f) => 'range' in f);